Refactor value + unit renderings to use unified layout#3277
Open
charliepark wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT
When I was working on #3214, I came across a number of occasions where we rendered a value and a unit, like
6 vCPUsor128 GiB. We had a few different ways of rendering those. This PR creates a new component,<ValueUnit>, which renders the value, formatted, and the unit, also formatted. It also adds a<Size>component, built on top of<ValueUnit>.Currently, the files changed in this branch do NOT step on the toes of main...standardize-unit-helpers, which is addressing some of the notes in https://gist.github.com/david-crespo/5fe725886475d18afa6cc459daf1acc3. Nevertheless, it might be best for that one to get wrapped up and merged first.
One thing to note is that the value/units in SiloQuotasTab (not addressed in this PR) currently use
text-secondary, rather than text-tertiary, so we might want to fold that one in as well to using the new ValueUnit component.Closes #3276