Conversation
Phase 1/7 of OPRUN-4738: remove object-controller's dependency on operator-controller's internal metadata package. Move the label constants into internal/shared/labels and update imports in both controllers and their tests. Generalize the object-controller comments to describe owners rather than ClusterExtensions. Review focus: the package move and mechanical import changes. Metadata keys and reconciliation behavior are unchanged. No generated files. Refs: OPRUN-4738 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Add a dedicated manager with a ClusterObjectSet-only scheme and regression coverage. Reuse referenced Secret reads within each reconciliation, retry transient read failures, and show numeric revision status when no bundle version is present. Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Add object-controller to local and Linux builds, Docker image creation, KIND loading, and multi-architecture GoReleaser output. Refs: OPRUN-4774 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Move ClusterObjectSet CRD and deployment ownership to object-controller. Remove the embedded ClusterObjectSet manager from operator-controller, and update local development, installation, and documentation paths. Add chart rendering coverage for standalone, Boxcutter, downstream, and PodDisruptionBudget configurations. Refs: OPRUN-4775 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Include the standalone object-controller deployment, RBAC, networking, metrics, and disruption budget in the generated experimental installation manifests. Refs: OPRUN-4775 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
The standalone controller is the only ClusterObjectSet reconciler after the cutover. Reject an explicit objectController.enabled=false when operator-controller has an effective BoxcutterRuntime gate so Helm cannot render an installation without a reconciler or CRD. Cover the invalid combination and the inactive-gate boundary in chart tests. Refs: OPRUN-4775 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The nine direct ClusterObjectSet scenarios now have an
@ObjectControllertag and dedicated step definitions. The E2E runner discovers the object-controller Deployment independently, uses its namespace for readiness, and provides--e2e.object-controller-onlyto require an installation without ClusterExtension or ClusterCatalog APIs. An explicitly requested standalone suite or integrated Boxcutter suite fails readiness when object-controller is missing. The E2E README documents the standalone command.This implements OPRUN-4776 under OPRUN-4738. It depends on #2949 (OPRUN-4775); review the focused branch comparison for this slice. The original combined work is #2938. This draft targets
main, so its Files changed tab also includes earlier stacked subtasks until they merge.Validation
make verifypassed on the rebased branch. Targeted Go lint reported zero issues. The race-enabled E2E selection test passed all seven cases, and the feature runner compiled.features/install.feature:11ClusterExtension installation passed one scenario and eleven steps, including catalog resolution, rollout, bundle version, and managed resources.make docker-build IMAGE_TAG=oprun-4776-integrationpassed.Reviewer Checklist
Always review AI generated responses prior to use.
AI-assisted response via openshift-developer plugin