feat(incident,maintenance): select affected services from a list instead of typing IDs#228
Open
wispy92 wants to merge 1 commit into
Open
Conversation
…d of typing IDs The incident form required pasting a raw service_id and the maintenance form a free-text comma-separated list, so users had to know internal IDs and exact service names. Both now use the uptime services list. - Incident: the "Service ID" field becomes a dropdown of uptime services (single select, with a status dot) that writes the chosen service's id to service_id. - Maintenance: "Affected services" becomes a multi-select — pick services from a dropdown, shown as removable badges; still stored in the existing `affected` text field as comma-separated service names. Frontend-only. Create and edit dialogs both reuse these field components. No new i18n keys (reuses serviceId / selectUptimeService / affectedServices). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Let users pick the affected service(s) for an incident or a maintenance from the uptime-services list, instead of typing a raw service ID / service names by hand.
Why
How
IncidentBasicFields): the Service ID field is now a dropdown of uptime services (single select, with a status dot, mirroring the operational-pageComponentsSelector). It writes the selected service'sidtoservice_id— unchanged data shape.MaintenanceAffectedFields): Affected services becomes a multi-select — add services from a dropdown, shown as removable badges. Still stored in the existingaffectedtext field as a comma-separated list of service names, so downstream display (table, detail dialog) is unchanged.serviceId,selectUptimeService,affectedServices).Testing
npx tsc --noEmit,npx eslint(changed files), andnpx vite buildall pass.