Skip to content

Refresh conditions while pods are active - #594

Open
srac0 wants to merge 1 commit into
openstack-k8s-operators:mainfrom
srac0:refresh-conditions
Open

Refresh conditions while pods are active#594
srac0 wants to merge 1 commit into
openstack-k8s-operators:mainfrom
srac0:refresh-conditions

Conversation

@srac0

@srac0 srac0 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Pending and running pods returned before config and network conditions could be refreshed. Continue reconciling those checks while a pod is active.

@srac0 srac0 self-assigned this Nov 2, 2026
@openshift-ci

openshift-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 730fd1f2-d708-4686-8f3c-b792042e7026
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Nov 2, 2026

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/c1373153951e444485e808e195b43f61

✔️ test-operator-s2i-content-provider SUCCESS in 3h 45m 02s (non-voting)
✔️ test-operator-kuttl-s2i SUCCESS in 40m 11s (non-voting)
✔️ test-operator-s2i-test SUCCESS in 2h 24m 48s (non-voting)
✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 54m 52s
✔️ test-operator-kuttl SUCCESS in 36m 23s
✔️ podified-multinode-edpm-deployment-crc-test-operator SUCCESS in 2h 33m 15s

Warning:
File .ssh/known_hosts.old found in build home directory during playbook review.rdoproject.org/config/playbooks/base-minimal/post-logs.yaml for job test-operator-s2i-test. Add to preserve-home-paths if safe, or otherwise remove.
File .ssh/config found in build home directory during playbook github.com/openstack-k8s-operators/s2i-openstack-containers/playbooks/container-ci/zuul/pre.yaml for job test-operator-s2i-content-provider. Add to preserve-home-paths if safe, or otherwise remove.
File .ssh/known_hosts.old found in build home directory during playbook review.rdoproject.org/config/playbooks/base-minimal/post-logs.yaml for job podified-multinode-edpm-deployment-crc-test-operator. Add to preserve-home-paths if safe, or otherwise remove.

kstrenkova
kstrenkova reviewed Nov 3, 2026
View reviewed changes

@kstrenkova kstrenkova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm. I am still thinking of cases that could break the pods, now that Wait and CheckPending are exposed to more code. 🤔 I will revisit your PR again to check it more, but so far it looks good.

Comment thread internal/controller/common_controller.go Resolved
Comment thread internal/controller/common_controller.go Resolved
@srac0
srac0 force-pushed the refresh-conditions branch 2 times, most recently from 9d785fe to ffe61d9 Compare November 3, 2026 09:32
@srac0
srac0 marked this pull request as ready for review November 3, 2026 09:37
@openshift-ci
openshift-ci Bot requested review from abays and evallesp November 3, 2026 09:37
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Nov 3, 2026

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/eb798f8f311f4a35915f3fab4e1372ae

✔️ test-operator-s2i-content-provider SUCCESS in 3h 47m 27s (non-voting)
❌ test-operator-kuttl-s2i NODE_FAILURE Node(set) request 099-0000258956 failed in 0s (non-voting)
✔️ test-operator-s2i-test SUCCESS in 2h 07m 38s (non-voting)
✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 49m 50s
✔️ test-operator-kuttl SUCCESS in 35m 19s
✔️ podified-multinode-edpm-deployment-crc-test-operator SUCCESS in 2h 19m 57s

Warning:
File .ssh/known_hosts.old found in build home directory during playbook review.rdoproject.org/config/playbooks/base-minimal/post-logs.yaml for job test-operator-s2i-test. Add to preserve-home-paths if safe, or otherwise remove.
File .ssh/config found in build home directory during playbook github.com/openstack-k8s-operators/s2i-openstack-containers/playbooks/container-ci/zuul/pre.yaml for job test-operator-s2i-content-provider. Add to preserve-home-paths if safe, or otherwise remove.
File .ssh/known_hosts.old found in build home directory during playbook review.rdoproject.org/config/playbooks/base-minimal/post-logs.yaml for job podified-multinode-edpm-deployment-crc-test-operator. Add to preserve-home-paths if safe, or otherwise remove.

@srac0 srac0 added the ready-for-review Marks additional review needed label Nov 3, 2026
kstrenkova
kstrenkova reviewed Nov 6, 2026
View reviewed changes

@kstrenkova kstrenkova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, overall I really don't see any obvious issues with the PR. I wanted to take time and check every possible small bug and this is what I arrived at. If you disagree with some of the suggestions, please let me know! I am open to discussion :D

Comment thread internal/controller/common_controller.go Resolved
Comment thread internal/controller/common_controller.go Resolved
Comment thread internal/controller/common_controller.go Resolved
@srac0
srac0 force-pushed the refresh-conditions branch from ffe61d9 to ff5bdc5 Compare November 6, 2026 14:55
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Nov 7, 2026

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/2cd74f2d31334b30b74cb5467cd1c9ab

✔️ test-operator-s2i-content-provider SUCCESS in 8h 31m 19s
✔️ test-operator-kuttl-s2i SUCCESS in 40m 36s
✔️ test-operator-s2i-test SUCCESS in 2h 11m 14s
✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 27m 20s
✔️ test-operator-kuttl SUCCESS in 38m 01s
✔️ podified-multinode-edpm-deployment-crc-test-operator SUCCESS in 2h 20m 31s

Warning:
File .ssh/config found in build home directory during playbook github.com/openstack-k8s-operators/s2i-openstack-containers/playbooks/container-ci/zuul/pre.yaml for job test-operator-s2i-content-provider. Add to preserve-home-paths if safe, or otherwise remove.

hjensas
hjensas approved these changes Nov 9, 2026
View reviewed changes

@hjensas hjensas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive this change would fix the CI error seen here: https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/a740e3a0b08549e5bc401d09667e0b1d

The test runner pod was running, yet the ServiceConfigReady was false.

@openshift-ci openshift-ci Bot added the lgtm label Nov 9, 2026
@srac0
Refresh conditions while pods are active
24be205 
Pending and running pods returned before config and network conditions
could be refreshed. Continue reconciling those checks while a pod is active.

Signed-off-by: Samuel Rac <srac@redhat.com>
@srac0
srac0 force-pushed the refresh-conditions branch from ff5bdc5 to 24be205 Compare November 9, 2026 11:21
@openshift-ci openshift-ci Bot removed the lgtm label Nov 9, 2026
kstrenkova
kstrenkova approved these changes Nov 9, 2026
View reviewed changes

@kstrenkova kstrenkova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and making all needed changes. Lgtm.

@openshift-ci openshift-ci Bot added the lgtm label Nov 9, 2026
@openshift-ci

openshift-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjensas, kstrenkova, srac0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Nov 9, 2026
@hjensas hjensas mentioned this pull request Nov 9, 2026
Open
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Nov 9, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/0f7d26b4c16c42b18a60b8b05b365874

❌ test-operator-s2i-content-provider FAILURE in 2m 55s
⚠️ test-operator-kuttl-s2i SKIPPED Skipped due to failed job test-operator-s2i-content-provider
⚠️ test-operator-s2i-test SKIPPED Skipped due to failed job test-operator-s2i-content-provider
❌ openstack-k8s-operators-content-provider FAILURE in 5m 12s
⚠️ test-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Warning:
File .ssh/config found in build home directory during playbook github.com/openstack-k8s-operators/s2i-openstack-containers/playbooks/container-ci/zuul/pre.yaml for job test-operator-s2i-content-provider. Add to preserve-home-paths if safe, or otherwise remove.

@srac0

srac0 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

recheck

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjensas hjensas hjensas approved these changes
@kstrenkova kstrenkova kstrenkova approved these changes
@abays abays Awaiting requested review from abays
@evallesp evallesp Awaiting requested review from evallesp

Assignees

@hjensas hjensas

@srac0 srac0

@kstrenkova kstrenkova

Labels

approved lgtm ready-for-review Marks additional review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@srac0 @hjensas @kstrenkova