[cifmw_backup_restore] Add baremetal backup/restore support#4022
Conversation
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 18m 56s |
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 53s |
|
recheck |
michburk
left a comment
There was a problem hiding this comment.
Some minor comments, generally lgtm
Add support for backing up and restoring baremetal-provisioned compute nodes (BaremetalHosts and OpenStackBaremetalSets). This uses the annotation-based approach from OSPRH-29980 and OSPRH-29529, eliminating the previous workaround of scaling down the openstack-baremetal operator and manually deleting its webhooks. Backup: conditionally creates a separate BMH backup when BaremetalHosts are in a different namespace than OpenStack resources. Restore: adds Steps 9a (BMH restore with status + unpause) and 9b (OSBMS restore with status + annotation removal) between the full deployment resume and the DataPlane restore. The resource modifier template conditionally injects BMH pause, OSBMS webhook-skip, and OSBMS reconcile-pause annotations during restore. All baremetal steps are gated behind cifmw_backup_restore_baremetal (default: false) so existing workflows are unaffected. Jira: OSPRH-31756 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Andrew Bays <abays@redhat.com>
abc6a93 to
67b5780
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michburk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add support for backing up and restoring baremetal-provisioned compute nodes (BaremetalHosts and OpenStackBaremetalSets). This uses the annotation-based approach from OSPRH-29980 and OSPRH-29529, eliminating the previous workaround of scaling down the openstack-baremetal operator and manually deleting its webhooks.
Backup: conditionally creates a separate BMH backup when BaremetalHosts are in a different namespace than OpenStack resources.
Restore: adds Steps 9a (BMH restore with status + unpause) and 9b (OSBMS restore with status + annotation removal) between the full deployment resume and the DataPlane restore. The resource modifier template conditionally injects BMH pause, OSBMS webhook-skip, and OSBMS reconcile-pause annotations during restore.
All baremetal steps are gated behind cifmw_backup_restore_baremetal (default: false) so existing workflows are unaffected.
Jira: OSPRH-31756
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Signed-off-by: Andrew Bays abays@redhat.com