fix: add curl retry flags to ARO-HCP capz-e2e build root (ARO-29016) by RadekCap · Pull Request #83383 · openshift/release

RadekCap · 2026-08-13T12:53:56Z

Description

Add --retry 3 --retry-delay 5 to all external curl downloads in the
dockerfile_literal build root for the ARO-HCP capz-e2e CI jobs. Without
retry flags, a single transient DNS failure kills the entire CI image build
before any test step runs.

Root cause confirmed in periodic run 2087630250363064320 of
periodic-ci-Azure-ARO-HCP-main-capz-e2e-production:
curl: (6) Could not resolve host: dl.k8s.io — the kubectl download step
failed, causing the build to exit in ~8 minutes with no test execution.

JIRA: https://redhat.atlassian.net/browse/ARO-29016

Changes Made

Added --retry 3 --retry-delay 5 to the oc download from mirror.openshift.com
Added --retry 3 --retry-delay 5 to the kubectl binary download from dl.k8s.io
Added --retry 3 --retry-delay 5 to the kubectl checksum download from dl.k8s.io
Added --retry 3 --retry-delay 5 to the helm tarball download from get.helm.sh
Added --retry 3 --retry-delay 5 to the helm checksum download from get.helm.sh
Added --retry 3 --retry-delay 5 to the clusterctl download from GitHub

Configuration Changes

N/A

Additional Notes

The same fix has been applied to Dockerfile.prow in
stolostron/capi-tests#812,
which is the source the dockerfile_literal here was copied from.

🤖 Generated with Claude Code

Summary by CodeRabbit

The ARO-HCP capz-e2e CI image build now retries external curl downloads three times, with a five-second delay between attempts. This covers oc, kubectl, Helm, their checksums, and clusterctl.

This reduces CI image build failures caused by transient DNS or network errors.

The dockerfile_literal used to build the capz-e2e CI image had no retry logic on any of the external curl downloads (kubectl, helm, clusterctl, oc). A single transient DNS failure kills the entire build before any test step runs — confirmed in run 2087630250363064320 where dl.k8s.io failed to resolve. Add --retry 3 --retry-delay 5 to all five curl download commands. Ref: ARO-29016 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-08-13T12:54:25Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2df64537-426e-4942-87c0-4b14fb0d24fa

📥 Commits

Reviewing files that changed from the base of the PR and between 3dce05a and ccb7d0a.

📒 Files selected for processing (1)

ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__capz-e2e.yaml

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-08-13T12:54:26Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2df64537-426e-4942-87c0-4b14fb0d24fa

📥 Commits

Reviewing files that changed from the base of the PR and between 3dce05a and ccb7d0a.

📒 Files selected for processing (1)

ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__capz-e2e.yaml

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-08-13T12:54:31Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2df64537-426e-4942-87c0-4b14fb0d24fa

📥 Commits

Reviewing files that changed from the base of the PR and between 3dce05a and ccb7d0a.

📒 Files selected for processing (1)

ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__capz-e2e.yaml

Walkthrough

The CI configuration adds three-attempt retries with five-second delays to downloads for the OpenShift CLI, kubectl, Helm, and clusterctl. Existing checksum validation, extraction, and installation steps remain unchanged.

Changes

Download reliability

Layer / File(s)	Summary
Configure tool download retries `ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__capz-e2e.yaml`	OpenShift CLI, kubectl, Helm, and clusterctl downloads now retry three times with a five-second delay between attempts.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to ccb7d

This localized change adds retries to external downloads and presents no actionable merge-blocking risk beyond the normal confirmation that generated CI configuration is up to date.

Suggested reviewers: marek-veber, roivaz

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes adding curl retry flags to the ARO-HCP capz-e2e build root.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The HEAD diff changes only six curl commands in a YAML Dockerfile literal; it adds no Ginkgo test titles or dynamic test-name content.
Test Structure And Quality	✅ Passed	The commit changes only six curl download lines in one YAML dockerfile_literal; it adds no Ginkgo It blocks, setup, cleanup, waits, or assertions to review.
Microshift Test Compatibility	✅ Passed	The diff changes only six curl commands in one YAML build configuration; it adds no Ginkgo tests or MicroShift-sensitive API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only six curl commands in one YAML Dockerfile literal; its diff adds no Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only adds curl retry flags in a CI Dockerfile literal; it adds no deployment, operator, controller, or scheduling constraints covered by this check.
Ote Binary Stdout Contract	✅ Passed	The diff changes only six curl commands in a YAML Dockerfile literal by adding retry flags; it introduces no OTE process-level code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only six curl commands in one YAML build root; the parent diff adds no Ginkgo tests or test networking assumptions.
No-Weak-Crypto	✅ Passed	The HEAD diff only adds curl retry flags to six download commands; existing SHA-256 verification is unchanged, and no MD5, SHA-1, weak cipher, custom crypto, or secret comparison was introduced.
Container-Privileges	✅ Passed	The commit only adds curl retry flags to six RUN commands; it adds no privileged, host namespace, SYS_ADMIN, allowPrivilegeEscalation, or root-setting declarations.
No-Sensitive-Data-In-Logs	✅ Passed	The HEAD^..HEAD diff only adds retry flags to six existing curl downloads; it adds no logging options, credentials, tokens, PII, or sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-merge-bot · 2026-08-13T12:56:54Z

[REHEARSALNOTIFIER]
@RadekCap: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-Azure-ARO-HCP-main-capz-e2e-dev	Azure/ARO-HCP	presubmit	Ci-operator config changed
pull-ci-Azure-ARO-HCP-main-capz-e2e-images	Azure/ARO-HCP	presubmit	Ci-operator config changed
periodic-ci-Azure-ARO-HCP-main-capz-e2e-production	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2026-08-13T12:59:18Z

@RadekCap: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

marek-veber

/lgtm

openshift-ci · 2026-08-13T13:02:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marek-veber, RadekCap
Once this PR has been reviewed and has the lgtm label, please assign geoberle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

ci-operator/config/Azure/ARO-HCP/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci Bot requested review from deads2k and mmazur August 13, 2026 12:54

marek-veber approved these changes Aug 13, 2026

View reviewed changes

openshift-ci Bot assigned marek-veber Aug 13, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2026

Navigation Menu

Uh oh!

fix: add curl retry flags to ARO-HCP capz-e2e build root (ARO-29016) - #83383

fix: add curl retry flags to ARO-HCP capz-e2e build root (ARO-29016)#83383
RadekCap wants to merge 1 commit into
openshift:mainfrom
RadekCap:ARO-29016-fix-curl-retry-arohcp

RadekCap commented Aug 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 13, 2026

Uh oh!

coderabbitai Bot commented Aug 13, 2026

Uh oh!

coderabbitai Bot commented Aug 13, 2026 •

edited

Loading

Uh oh!

openshift-merge-bot Bot commented Aug 13, 2026

Uh oh!

openshift-ci Bot commented Aug 13, 2026

Uh oh!

marek-veber left a comment

Uh oh!

openshift-ci Bot commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

RadekCap commented Aug 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes Made

Configuration Changes

Additional Notes

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 13, 2026

Uh oh!

coderabbitai Bot commented Aug 13, 2026

Uh oh!

coderabbitai Bot commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-merge-bot Bot commented Aug 13, 2026

Uh oh!

openshift-ci Bot commented Aug 13, 2026

Uh oh!

marek-veber left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RadekCap commented Aug 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 13, 2026 •

edited

Loading