INTEROP-9406: Update OPP 4.22 interop jobs to install ACM 2.17.z - #82898
INTEROP-9406: Update OPP 4.22 interop jobs to install ACM 2.17.z#82898amp-rh wants to merge 2 commits into
Conversation
The OCP 4.22 interop and upgrade jobs were installing ACM 2.16.z, which is outdated. Update operator channel from release-2.16 to release-2.17 and bump ACM QE test image references from 2.16 to 2.17 across all OPP 4.22 variants (AWS, vSphere, upgrade). Resolves: https://redhat.atlassian.net/browse/INTEROP-9406
|
@amp-rh: GitHub didn't allow me to request PR reviews from the following users: CSPI-QE. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughThe OCP 4.22 policy collection configuration now uses ACM 2.17 images and channels. The OPP preflight compatibility matrix now requires ACM 2.17. ChangesACM 2.17 CI alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse periodic-ci-stolostron-policy-collection-main-ocp4.22-interop-opp-aws |
Review: ACM 2.16 → 2.17 for OPP 4.22I reviewed the diff, the full post-PR file content, and the OPP preflight compatibility matrix. Here are my findings: ✅ 1. All references updated — no stale 2.16 refs remainAfter applying the PR, a full scan of both files confirms zero remaining
Other operator references ( ✅ 2.
|
|
@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Align the preflight version check with the operator channel change: ACM minimum version for OCP 4.22 is now 2.17, matching the OPERATORS channel in the interop job configs.
Verification: Second commit (preflight matrix update)Following up on my earlier review, the second commit addresses the non-blocking note I raised about the OPP preflight compatibility matrix. Here's the full verification: ✅ 1. Preflight matrix change is correct and consistentThe change on line 75 of -OPP_COMPAT["4.22"]="advanced-cluster-management:2.16 rhacs-operator:4.11 odf-operator:4.22 quay-operator:3.16"
+OPP_COMPAT["4.22"]="advanced-cluster-management:2.17 rhacs-operator:4.11 odf-operator:4.22 quay-operator:3.16"
✅ 2. No remaining ACM 2.16 references for OCP 4.22I searched the full
No stale ACM 2.16 references remain for OCP 4.22. ✅ 3. PR is completeThe two commits together cover all necessary changes for the ACM 2.16→2.17 update on OCP 4.22:
LGTM — the PR is now complete and consistent across all layers. AI-generated verification. Review for accuracy. AI-generated. Review for accuracy. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amp-rh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse periodic-ci-stolostron-policy-collection-main-ocp4.22-interop-opp-aws |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@amp-rh: This pull request references INTEROP-9406 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse ack The rehearsal job has verified the ACM 2.16→2.17 version change. All critical ACM-related steps passed successfully:
This confirms ACM 2.17 deploys and functions correctly on OCP 4.22. Any remaining test failures in later steps are pre-existing and unrelated to this version bump. AI-generated. Review for accuracy. |
|
@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack The rehearsal job has passed the critical ACM-related steps, confirming that the ACM 2.16 → 2.17 version bump works correctly on OCP 4.22:
Any remaining test failures in the rehearsal are pre-existing and unrelated to this version change. The ACM 2.17 deployment path on OCP 4.22 is confirmed working. AI-generated. Review for accuracy. |
|
@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack The two upgrade rehearsal failures ( The interop rehearsals ( |
|
@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@amp-rh: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Test/Operator Version Mismatch — Root Cause AnalysisIssue: Since Aug 12, the Root cause: PR #82365 (INTEROP-9357) merged on Aug 11 at 11:25 UTC and changed the
This PR fixes it. PR #82898 updates the Rehearsal validation: I checked the opp-aws rehearsal for this PR and confirmed:
AI-generated. Review for accuracy. |
|
@amp-rh: This pull request references INTEROP-9406 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
TL;DR
Bump ACM from 2.16.z to 2.17.z across all OPP 4.22 interop jobs (AWS, vSphere, upgrade) and the preflight compatibility matrix.
What changed
release-2.16→release-2.17in all 3 OPP 4.22 job variantsacmqe-grc-test,clc-ui-e2e,multicluster-observability-operator-opp):2.16→2.17Core file (review this first)
ci-operator/step-registry/interop/opp/preflight/interop-opp-preflight-commands.shMechanical/config files
.../stolostron-policy-collection-main__ocp4.22.yaml2.16→2.17).../stolostron-policy-collection-main__ocp4.22-upgrade.yaml2.16→2.17)Risk areas
Testing
Resolves: INTEROP-9406
/cc @CSPI-QE