[release-5.0] OCPBUGS-112657: Handle Sippy date-only format in featuregate-test-analyzer - #3007
Conversation
Sippy PR openshift/sippy#3716 changed the development_start and ga fields in /api/releases from RFC 3339 timestamps to bare date strings (e.g. "2018-07-11"), which broke getLatestRelease() in the featuregate-test-analyzer with: parsing time "2018-07-11" as "2006-01-02T15:04:05Z07:00": cannot parse "" as "T" Add a flexibleDateTime wrapper whose UnmarshalJSON tries RFC 3339 first and falls back to the date-only layout ("2006-01-02"), so both the old and new /api/releases response formats are handled. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sippy PR openshift/sippy#3716 changed the timestamp column backing /api/jobs/runs to a raw timestamptz Postgres type. BuildSippyJobRunsForJobURL() was sending the >= filter value as epoch milliseconds (fmt.Sprintf("%d", timestamp.UnixMilli())), which Postgres cannot parse as a timestamp, so the /api/jobs/runs call failed. Send the filter value as an RFC 3339 string (timestamp.UTC().Format(time.RFC3339), e.g. "2026-08-07T00:00:00Z") which Postgres parses natively as timestamptz. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api: |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-112479 has been cloned as Jira Issue OCPBUGS-112657. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-112657, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@neisw: This pull request references Jira Issue OCPBUGS-112657, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick release-4.22 |
|
@neisw: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label backport-risk-assessed |
|
@neisw: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neisw The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This is an automated cherry-pick of #2998
/assign neisw