OCPBUGS-74507: Remove ServiceAccountTokenNodeBinding feature gate

[ibihim]

What

Remove the ServiceAccountTokenNodeBinding feature gate.

Why

It is GA and locked to true in Kubernetes since 1.33 (kube_features.go#L1722-L1726). Our explicit enablement is a no-op.

FeatureGateServiceAccountTokenNodeBinding has no consumers in the org, therefore no o/kubernetes → o/origin bump is needed beforehand.

First commit is the hand edit, second commit is make update-payload-featuregates.

https://redhat.atlassian.net/browse/OCPBUGS-74507

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @ibihim! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@ibihim: This pull request references Jira Issue OCPBUGS-74507, which is invalid:

• expected the bug to target either version "5.1.0." or "openshift-5.1.0.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What

Remove the ServiceAccountTokenNodeBinding feature gate.

Why

It is GA and locked to true in Kubernetes since 1.33 (kube_features.go#L1722-L1726). Our explicit enablement is a no-op.

FeatureGateServiceAccountTokenNodeBinding has no consumers in the org, therefore no o/kubernetes → o/origin bump is needed beforehand.

First commit is the hand edit, second commit is make update-payload-featuregates.

https://redhat.atlassian.net/browse/OCPBUGS-74507

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b0d01009-8914-4e30-910c-ae04eb61b844

📥 Commits

Reviewing files that changed from the base of the PR and between 3db6c4b and 734fe96.

📒 Files selected for processing (10)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

💤 Files with no reviewable changes (10)

• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• features.md
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• features/features.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes ServiceAccountTokenNodeBinding from the feature-gate status table. It also removes the feature gate from enabled or disabled lists in the 4.10 HyperShift and SelfManagedHA manifests. The feature-gate registration is removed from features/features.go.

Merge Risk: ⚪ Minimal · up to 734fe

This PR removes an obsolete feature-gate setting and its generated references without any identified merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely states that the ServiceAccountTokenNodeBinding feature gate is being removed.
Description check	✅ Passed	The description explains the removal and gives the reason that the feature gate is GA and locked to true in Kubernetes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR diff only removes a feature-gate declaration and manifest entries; it adds or modifies no Ginkgo test titles or dynamic test-name expressions.
Test Structure And Quality	✅ Passed	The diff contains only feature-gate Go, Markdown, and YAML deletions; no Ginkgo test files, It blocks, cluster operations, or assertions were added or changed.
Microshift Test Compatibility	✅ Passed	The PR diff contains only deletions in feature metadata, Go registration, and YAML manifests; it adds no Ginkgo e2e tests to assess for MicroShift compatibility.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The complete PR diff has only feature-gate metadata and manifest deletions; it changes no Go test files and adds no Ginkgo tests.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only feature-gate registry/docs and FeatureGate status payloads; the diff adds no deployment/controller code or scheduling fields, so no listed topology failure is introduced.
Ote Binary Stdout Contract	✅ Passed	The PR diff has 0 added lines and only removes a feature-gate registration, documentation, and YAML entries; it introduces no OTE process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The complete PR diff contains only feature-gate and manifest deletions; it adds no Ginkgo e2e tests or network/external-connectivity code.
No-Weak-Crypto	✅ Passed	The PR diff contains only deletions of a feature-gate registration and manifest entries; it adds no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges	✅ Passed	The PR only removes a feature-gate registration, documentation row, and FeatureGate status entries; no container/Kubernetes privilege fields were added or changed.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only deletes a feature-gate declaration, documentation row, and manifest entries; the diff adds no logging calls or sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[everettraven]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[everettraven]

Known failure due to sippy date format changes for releases. This is removing an already GA feature gate.

/override ci/prow/verify-feature-promotion

[openshift-ci]

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-feature-promotion

Details

In response to this:

Known failure due to sippy date format changes for releases. This is removing an already GA feature gate.

/override ci/prow/verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@ibihim: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-techpreview	734fe96	link	true	/test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.