OCPBUGS-83412: Disable PSA for placeholder for 5.0 - #3002
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@oceanc80: This pull request references Jira Issue OCPBUGS-83412, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (xxia@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Hello @oceanc80! Some important instructions when contributing to openshift/api: |
|
/lgtm |
|
@oceanc80 This PR needs a rebase before it can be merged |
|
Hypershift -> they watch the feature gate. |
|
Scheduling tests matching the |
647592f to
7f33457
Compare
IIRC yes.
Yes, but the 4.23 branch automatically gets all updates to the 5.0 branch so while we have a ticket to track the same changes in 4.23, there's nothing to do for it other than to ensure that these changes also land in the 4.23 branch. |
Done :) |
|
/lgtm |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, ibihim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@oceanc80: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Disables the
OpenShiftPodSecurityAdmissionfeature gate by defaultfor 5.0, mirroring the fix from #2802 (4.22).
In
features/features.go, theOpenShiftPodSecurityAdmissionfeaturegate's
enable()call is changed from:to:
This removes default enablement on both OCP and OKD profiles, keeping
PSA available only in TechPreview and DevPreview.
All other file changes are generated by
make update.