OCPBUGS-105399,OCPBUGS-105400: Remove SigstoreImageVerification and SigstoreImageVerificationPKI feature gates

[amritansh1502]

Bug1: https://redhat.atlassian.net/browse/OCPBUGS-105399
Bug2: https://redhat.atlassian.net/browse/OCPBUGS-105400

Summary

The feature gates SigstoreImageVerification and SigstoreImageVerificationPKI have been enabled by default across all cluster profiles (Default, OKD, TechPreviewNoUpgrade, DevPreviewNoUpgrade) and are no longer needed within the product. This PR removes both gates entirely.
Related origin PR: openshift/origin#31521 (removes redundant IsTechPreviewNoUpgrade skip checks from the corresponding e2e tests).

Changes

Feature gate removal

• Removed FeatureGateSigstoreImageVerification and FeatureGateSigstoreImageVerificationPKI definitions from features/features.go
• Removed SigstoreImageVerification from legacy feature gate lists in both features/legacyfeaturegates.go and payload-command/render/legacyfeaturegates.go
• Removed both rows from features.md
• Removed SigstoreImageVerification from rendered manifests test expectations

And other corresponding generative changes

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @amritansh1502! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-105400, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug1: https://redhat.atlassian.net/browse/OCPBUGS-105399
Bug2: https://redhat.atlassian.net/browse/OCPBUGS-105400

Summary

The feature gates SigstoreImageVerification and SigstoreImageVerificationPKI have been enabled by default across all cluster profiles (Default, OKD, TechPreviewNoUpgrade, DevPreviewNoUpgrade) and are no longer needed within the product. This PR removes both gates entirely.
Related origin PR: openshift/origin#31521 (removes redundant IsTechPreviewNoUpgrade skip checks from the corresponding e2e tests).

Changes

Feature gate removal

• Removed FeatureGateSigstoreImageVerification and FeatureGateSigstoreImageVerificationPKI definitions from features/features.go
• Removed SigstoreImageVerification from legacy feature gate lists in both features/legacyfeaturegates.go and payload-command/render/legacyfeaturegates.go
• Removed both rows from features.md
• Removed SigstoreImageVerification from rendered manifests test expectations

And other corresponding generative changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: df2c039a-a012-40a3-b0cf-e1b5e7fc1b02

📥 Commits

Reviewing files that changed from the base of the PR and between 3db6c4b and 4b5a263.

⛔ Files ignored due to path filters (7)

• config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_clusterimagepolicies.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_imagepolicies.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• config/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !**/zz_generated*
• config/v1/zz_generated.featuregated-crd-manifests/clusterimagepolicies.config.openshift.io/AAA_ungated.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/clusterimagepolicies.config.openshift.io/SigstoreImageVerification.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/imagepolicies.config.openshift.io/AAA_ungated.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/imagepolicies.config.openshift.io/SigstoreImageVerification.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**

📒 Files selected for processing (21)

• config/v1/tests/clusterimagepolicies.config.openshift.io/AAA_ungated.yaml
• config/v1/tests/clusterimagepolicies.config.openshift.io/SigstoreImageVerificationPKI.yaml
• config/v1/tests/imagepolicies.config.openshift.io/AAA_ungated.yaml
• config/v1/tests/imagepolicies.config.openshift.io/SigstoreImageVerificationPKI.yaml
• config/v1/types_cluster_image_policy.go
• config/v1/types_image_policy.go
• features.md
• features/features.go
• features/legacyfeaturegates.go
• payload-command/render/legacyfeaturegates.go
• payload-command/render/renderassets/rendered_manifests_test.go
• payload-manifests/crds/0000_10_config-operator_01_clusterimagepolicies.crd.yaml
• payload-manifests/crds/0000_10_config-operator_01_imagepolicies.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

💤 Files with no reviewable changes (16)

• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• features.md
• payload-command/render/legacyfeaturegates.go
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• config/v1/tests/imagepolicies.config.openshift.io/SigstoreImageVerificationPKI.yaml
• config/v1/tests/clusterimagepolicies.config.openshift.io/SigstoreImageVerificationPKI.yaml
• config/v1/types_cluster_image_policy.go
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-command/render/renderassets/rendered_manifests_test.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• features/legacyfeaturegates.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

PKI validation for ImagePolicy and ClusterImagePolicy is now unconditional. The API annotations and generated CRD validation order were updated. Tests now cover valid PKI policies and invalid certificate subjects, CA roots, and configurations. Fulcio CA fixtures were updated. The SigstoreImageVerification and SigstoreImageVerificationPKI feature gates were removed from registrations, documentation, tests, and payload manifests.

Merge Risk: ⚪ Minimal · up to 4b5a2

This PR removes obsolete feature gates and updates the corresponding manifests, definitions, documentation, and expectations; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely identifies the removal of both Sigstore feature gates.
Description check	✅ Passed	The description directly explains why and how the two Sigstore feature gates are removed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (4 skipped: 4 unsupported.)
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The moved and added manifest test titles are static; title multisets match the base manifests, and scans found no IPs, UUIDs, dates, or generated names.
Test Structure And Quality	✅ Passed	Changed files add declarative OnCreate cases; each negative case has an expectedError. The unchanged Ginkgo generator provides setup, cleanup, and a 5s Eventually timeout.
Microshift Test Compatibility	✅ Passed	The parent-to-HEAD diff adds no Ginkgo It/Describe/Context/When tests. The changed test content is declarative YAML CRD fixtures, so this check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit adds no Ginkgo e2e tests or Ginkgo constructs. It changes declarative CRD validation YAML plus API and feature-gate code, so the SNO compatibility check is inapplicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes feature-gate registries, API validation, CRDs, tests, and feature-gate manifests; the diff adds no workloads or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The diff changes API annotations, feature registration, manifests, and test data only; it adds no OTE entry-point, suite-setup, or stdout/logging write.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds declarative CRD validation fixtures, not new Ginkgo e2e tests. The changes contain no IPv4 assumptions or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The PR adds no MD5, SHA-1, DES, RC4, 3DES, Blowfish, ECB, crypto implementation, or secret comparison; changed certificates use SHA-256 with RSA.
Container-Privileges	✅ Passed	The PR diff adds only image-policy CRDs/tests and feature-gate data; scans found no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or container root settings.
No-Sensitive-Data-In-Logs	✅ Passed	Changed files add no logging calls; fixtures use test-user@example.com/oidc.localhost and public CERTIFICATE data, with no private-key or credential markers.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[amritansh1502]

/jira refresh

[openshift-ci-robot]

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-105400, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[amritansh1502]

/jira refresh

[openshift-ci-robot]

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-105400, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

/pipeline auto

[openshift-merge-bot]

Pipeline controller notification

The pipeline-auto label has been added to this PR. Second-stage tests will be triggered automatically when all first-stage tests pass.

[amritansh1502]

/test verify-feature-promotion

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

@amritansh1502: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-upgrade	4b5a263	link	true	/test e2e-upgrade
ci/prow/e2e-aws-ovn-techpreview	4b5a263	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-gcp	4b5a263	link	true	/test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.