Skip to content

Fixed windows build errors - #230

Merged
kix007 merged 1 commit into
mainfrom
fix_win_build_issues
Jul 29, 2026
Merged

Fixed windows build errors#230
kix007 merged 1 commit into
mainfrom
fix_win_build_issues

Conversation

@kix007

@kix007 kix007 commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixed windows build errors

Related issue

Changes

Testing notes

Checklist

  • I built the app locally (npm run tauri dev or npm run tauri build) and verified the change works.
  • Frontend typecheck passes (npx tsc --noEmit).
  • Rust build passes (cargo check --manifest-path src-tauri/Cargo.toml).
  • If I added a new #[tauri::command], I registered it in src-tauri/src/lib.rs's generate_handler!.
  • If user-visible: I added a line to CHANGELOG.md under ## [Unreleased].
  • If this touches storage.rs, updater.rs, capabilities/, or the AI assistant code path, I flagged it in the summary above.

Summary by CodeRabbit

  • Bug Fixes
    • Improved Windows subprocess handling to prevent unnecessary console windows from appearing.

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
queryden Ready Ready Preview, Comment Jul 29, 2026 12:54pm

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f39ca987-ef04-42f9-89fb-f871deb7b372

📥 Commits

Reviewing files that changed from the base of the PR and between eb4dc05 and 2cebe39.

📒 Files selected for processing (1)
  • src-tauri/src/cli.rs

📝 Walkthrough

Walkthrough

Changes

Windows subprocess command setup

Layer / File(s) Summary
Standard library CommandExt import
src-tauri/src/cli.rs
The Windows helper imports CommandExt from the standard library while retaining the existing CREATE_NO_WINDOW behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: keens007

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the Windows-focused build fix reflected by the CommandExt import change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_win_build_issues

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kix007
kix007 merged commit 06faba2 into main Jul 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants