Adds map "The Straits"

[RickD004]

Description:

Adds "The Straits" map:

A map located around Denmark and the many surrounding straits: Kattegat, Skagerrak and the Danish straits (thus the name, meant to be a creative name like "Between Two Seas" and "Gateway to the Atlantic"). This map is themed in the early 1900s, the nations/NPCs are traditional and historical regions of Sweden-Norway, Denmark and the Germany.

Relatively small map with ~700k land tiles, similar to World

Inspired by this Discord thread with nearly 20 upvotes: https://canary.discord.com/channels/1284581928254701718/1482089104110911634/1482089104110911634

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0887e2d1-bbed-4e23-9605-f34d4e81dedb

📥 Commits

Reviewing files that changed from the base of the PR and between 1c6f4e3 and 10f3fa6.

📒 Files selected for processing (2)

• resources/lang/en.json
• src/core/game/Game.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• resources/lang/en.json
• src/core/game/Game.ts

---

Walkthrough

A new regional map "The Straits" is added: enum and category entry, source nation data and manifest, generator registration with playlist frequency, and an English translation.

Changes

The Straits Map Addition

Layer / File(s)	Summary
Game Type Definition src/core/game/Game.ts	GameMapType.TheStraits enum member is added and included in mapCategories.regional.
Map Data Definition map-generator/assets/maps/thestraits/info.json, resources/maps/thestraits/manifest.json	Map source asset defines nation names, coordinates, and flag identifiers; manifest specifies grid dimensions and land-tile counts.
Map Registry and Availability map-generator/main.go, src/server/MapPlaylist.ts	Map is registered in the generator and assigned frequency value 5 for playlist rotation.
Localization resources/lang/en.json	English translation "The Straits" is added for the new map type.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A new channel between shores,
Flags and names on mapped floors,
The Straits set sail tonight,
Tiles align in tidy sight,
New game seas call for fights.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Adds map "The Straits"' directly and clearly summarizes the main change—adding a new map to the game system.
Description check	✅ Passed	The description thoroughly explains the map's purpose, location, theme, size, inspiration, and confirms all required tasks (UI updates, translations, tests, testing).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

map-generator/assets/maps/thestraits/info.json (1)

1-137: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add attribution for the "thestraits" map to CREDITS.md.

The new map map-generator/assets/maps/thestraits/info.json does not have a corresponding attribution entry in CREDITS.md. Add a section for this map that includes the source (for example, OpenStreetMap, Natural Earth) and any applicable licenses.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@map-generator/assets/maps/thestraits/info.json` around lines 1 - 137, Add an
attribution entry in CREDITS.md for the new map named "thestraits" (the map's
JSON has "name": "thestraits" in info.json) that lists the source data (e.g.,
OpenStreetMap, Natural Earth, or the actual source you used), the applicable
license(s) (e.g., ODbL, CC-BY), and any author or contributor names; place it
under the maps/assets or Maps section consistent with existing entries and
mirror the format used by other map attributions in CREDITS.md.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@map-generator/assets/maps/thestraits/info.json`:
- Around line 1-137: Add an attribution entry in CREDITS.md for the new map
named "thestraits" (the map's JSON has "name": "thestraits" in info.json) that
lists the source data (e.g., OpenStreetMap, Natural Earth, or the actual source
you used), the applicable license(s) (e.g., ODbL, CC-BY), and any author or
contributor names; place it under the maps/assets or Maps section consistent
with existing entries and mirror the format used by other map attributions in
CREDITS.md.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 23cb7a1c-a3f3-4166-a1b6-6c7117a05185

📥 Commits

Reviewing files that changed from the base of the PR and between 2b04c56 and 1c6f4e3.

⛔ Files ignored due to path filters (4)

• map-generator/assets/maps/thestraits/image.png is excluded by !**/*.png
• resources/maps/thestraits/map.bin is excluded by !**/*.bin
• resources/maps/thestraits/map16x.bin is excluded by !**/*.bin
• resources/maps/thestraits/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (7)

• map-generator/assets/maps/thestraits/info.json
• map-generator/main.go
• resources/lang/en.json
• resources/maps/thestraits/manifest.json
• resources/maps/thestraits/thumbnail.webp
• src/core/game/Game.ts
• src/server/MapPlaylist.ts

[RickD004]

I cant reply to Rabbit, but as with most of my maps it uses OpenTopography, already credited in CREDITS.md

[VariableVince]

I cant reply to Rabbit, but as with most of my maps it uses OpenTopography, already credited in CREDITS.md

You can @ coderabbit in a comment and reply that way if needed, since it's not possible to reply to "Outside of diff range comments" indeed