fix: brand-sample jsdelivr URLs#39
Open
brian-smith-tcril wants to merge 2 commits into
Open
Conversation
without this, `jsdelivr` URLs point to CSS files that don't exist.
A few examples were added from a branch made before the directory rename. This fixes those new examples to use the new directory in the `jsdelivr` URLs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 14 14
Lines 414 414
Branches 16 16
=======================================
Hits 366 366
Misses 40 40
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feanil
reviewed
May 13, 2026
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Can you add a "How to update the dist folder" section to the README for if we want to make changes in the future. Sounds like it's just npm run prepack? but it would be good to add a pointer from the README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #38