chore: Upgrade Python requirements - #39028
Merged
Merged
Conversation
Contributor
Author
|
List of packages in the PR without any issue.
|
Contributor
Author
|
These Packages need manual review..
|
Open
5 tasks
DRF 3.18.0 changes how ListSerializer (many=True) reports child validation
errors: a list padded with empty dicts becomes a dict keyed by the index of
each failing item, with passing items omitted. That flips the JSON type of
the error response body from an array to an object:
3.17.2 [{},{"code":["This field is required."]},{}]
3.18.0 {"1":{"code":["This field is required."]}}
Several write endpoints hand these errors straight back to the caller, so
their error responses change shape. Those responses are part of our API
contract, and only one test in the repo pinned the format, so the change
would have gone out silently.
Hold at <3.18 so the migration can be made deliberately, with the usual
consideration for API consumers, rather than riding in on a routine
requirements bump. Resolves to 3.17.2, which retains the old shape.
Upstream change: encode/django-rest-framework#9837
Issue for unpinning: #39048
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
feanil
force-pushed
the
repo-tools/upgrade-python-requirements-457ab6f
branch
from
August 31, 2026 17:38
68685a8 to
56ee681
Compare
pylint 4.0.8 widens redundant-unittest-assert (W1503) to cover assertEqual with constant values, not just assertTrue/assertFalse, so the requirements bump in this branch turns this pre-existing line into a lint error: cms/djangoapps/contentstore/views/tests/test_videos.py:790:8: W1503: Redundant use of assertEqual with constant value (True, False) self.fail() is what the line means anyway -- the comment above it already says "Test should fail if video not found". Both forms raise AssertionError, so the behavior is unchanged; the message just loses its "True != False : " prefix. The PT009 noqa goes away with the unittest-style assertion. This was the only occurrence of the pattern in the repo. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
feanil
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python requirements update. Please review the changelogs for the upgraded packages.
Deleted obsolete pull_requests:
#39020