OBLS-744 Require minimum 3 chars before triggering product/location l…#403
Merged
Conversation
Collaborator
Author
|
Related PR: openboxes/openboxes#5921 |
awalkowiak
approved these changes
May 20, 2026
| export const appConfig = { | ||
| DEFAULT_DEBOUNCE_TIME: 100, | ||
| DEFAULT_SEARCH_DEBOUNCE_TIME: 800, | ||
| MIN_SEARCH_LENGTH: 3, |
Contributor
There was a problem hiding this comment.
Technically, this could be configurable, as it is on the backend. But for now, we can leave it as a const
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ookups
https://openboxes.atlassian.net/browse/OBLS-744
The product/location typeahead in
SearchButtoncurrently fires a lookup on every keystroke, which fetches the full unpaginated dataset (~13k products / ~5k locations on VVG). This PR gates the lookup behind aMIN_SEARCH_LENGTHthreshold and surfaces a clear hint to the user while below it.