chore: migrate linting and formatting to Biome#1939
Conversation
jbeckwith-oai
force-pushed
the
codex/biome-migration
branch
from
e122465 to
65668a1
Compare
jbeckwith-oai
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65668a1b06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "$schema": "https://biomejs.dev/schemas/2.4.16/schema.json", | ||
| "files": { | ||
| "includes": [ | ||
| "**", |
There was a problem hiding this comment.
When pnpm check runs, scripts/check invokes biome check ., so this broad ** include makes Biome handle repository files it cannot parse, such as extensionless bash scripts like scripts/bootstrap and the YAML workflow files. Biome's CLI option for this case is --files-ignore-unknown/files.ignoreUnknown, and the config reference says that option defaults to false; without enabling it or narrowing the globs to supported file types, CI/local checks can fail on unknown-file diagnostics before reaching the build/type checks.
Useful? React with 👍 / 👎.
| "test": "./scripts/test", | ||
| "build": "./scripts/build", | ||
| "prepublishOnly": "echo 'to publish, run pnpm build && (cd dist; npm publish)' && exit 1", | ||
| "format": "./scripts/format", |
There was a problem hiding this comment.
Can we keep entrypoints for:
./scripts/format./scripts/lint- as well as similarly in package.json here?
A lot of scripts/skills depend on those
2 participants
Summary
Migrates the repository from ESLint/Prettier to Biome 2.4.16 and aligns the tooling with the new pnpm setup on main.
biome.jsoncwith comments for follow-up import ordering, tabs migration, and ecosystem-test formatting.pnpm checkandpnpm fix.yarn.lock.@typescript-eslint/*.Validation
pnpm install --frozen-lockfilepnpm fixconvert-jsr-readme.cjsfixture/idempotence/real README assertions./scripts/build-denopnpm checkDETECT_BREAKING_CHANGES_COMPAT=1 pnpm checkpnpm testgit diff --check