Repository navigation
feat: retain native checklists in resumable sessions - #6137
markstuart-oai wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Approved after comprehensive static review and an independent second review. Verified the pinned Core emits plan updates only after parsing accepted tool arguments and stamps the owning turn ID. Reviewed native thread identity, exact turn filtering, latest-update replacement and empty-plan clearing, immutable checkpoint data, backward reading of older checkpoints, atomic save behavior, approval resumes, nested-agent isolation, and both Runner paths. No actionable findings.
The checklist is display data, not tool authorization or a resumable native thread. Older SDK versions rejecting checkpoints containing the new field is documented. Hosted CI is complete: 33 passed and 2 skipped; no failures. Static review only; no candidate code or local tests executed.
This pull request adds
session.codex_checklisttoResumableSession. Apps can display the last accepted checklist after a run ends or pauses for approval. Reopening the session needs no model call.Enable
tools.update_plan.enabled=truein the native provider and pass the session to either Runner mode. To read the saved list from an authorized store, use the same session ID.Each accepted update replaces the whole list. The snapshot includes the explanation, ordered steps, and native thread and turn IDs. An empty list means the tool cleared the checklist. Before the first accepted update, the property returns
None. Invalid tool arguments leave the previous list intact.The SDK saves the snapshot with the existing checkpoint. It grants no tool permissions. Older checkpoints remain readable. Older SDK versions may reject checkpoints that contain a checklist.
Test plan
Checks
.agents/skills/code-change-verification/scripts/run.sh(13,222 passed, 37 skipped)