Repository navigation
Stop retaining a copy of user text during history checks - #6086
Closed
markstuart-oai wants to merge 1 commit into
Closed
markstuart-oai wants to merge 1 commit into
markstuart-oai wants to merge 1 commit into
Conversation
markstuart-oai
marked this pull request as ready for review
November 19, 2026 02:23
markstuart-oai
requested review from
a team,
rm-openai and
seratch
as code owners
November 19, 2026 02:23
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Each history cursor has been keeping a second copy of up to 1 MiB of user text just to speed up later checks. This PR has been removing that copy while keeping the same byte limit and prefix hashes.
Summary
Repeat reads of the same long message have been trading speed for less retained text. For 256 KiB of text, check time has been rising from 31 to 497 µs in a local Rust probe. For a different message of the same size, time has been staying near 0.49 ms with or without the cache. These numbers have been measuring local history checks, not the time to run a turn.
Test plan
Both paths have been giving the same byte counts, hashes and errors in 83 cases, with a separate check over 8 MiB. The probe has been using the real budget and digest code with reduced message types. A fresh replay of all 112 patches has been matching the new tree, and all 51 source integrity tests have been passing. Full native tests have still been pending.
Issue number
None.
Checks