Repository navigation
Remove the Python SDK's native CA conversion cache - #6083
Closed
markstuart-oai wants to merge 1 commit into
Closed
markstuart-oai wants to merge 1 commit into
markstuart-oai wants to merge 1 commit into
Conversation
markstuart-oai
marked this pull request as ready for review
November 19, 2026 02:21
markstuart-oai
requested review from
a team,
rm-openai and
seratch
as code owners
November 19, 2026 02:21
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The SDK keeps converted CA certificates for reuse across clients, even though it must read the trust file each time. This PR drops that cache and builds each new client's trust list from the current file.
Summary
The TLS verifier, proxy rules and HTTP pool stay the same. The change cuts the extra production code in
custom_ca.rsfrom 258 lines over stock to 174. No API changes.The tradeoff is slower setup for a fresh client. In a local test that built a client and made one TLS request, the median cost rose by 0.13 ms with one root. With a large CA bundle it rose by about 15 ms. That test did not measure pooled requests or live service traffic.
Test plan
Issue number
None.
Checks
AGENTS.md, including.agents/skills/code-change-verification/scripts/run.shwhen requiredAGENTS.md