fix: #3282 reject unsupported Chat Completions reusable prompts#3283
Merged
seratch merged 1 commit intoMay 9, 2026
Merged
Conversation
Aphroq
changed the title
Aphroq
changed the title
seratch
requested changes
May 8, 2026
Member
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Can you resolve the conflicts?
Aphroq
force-pushed
the
fix/chat-completions-prompt-validation
branch
from
154d9d3 to
8ec5355
Compare
Contributor
Author
|
Resolved. |
seratch
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
OpenAIChatCompletionsModelreject reusablepromptvalues with a clearUserErrorinstead of accepting and dropping them beforechat.completions.create().This keeps the existing
prompt=Nonepath unchanged and covers both non-streaming and streaming Chat Completions calls. I also checked the adjacent Responses model path, which already sendsprompt, and the related server-managed state issue #3275 / PR #3279, which is a separate unsupported-parameter case.Test plan
uv run pytest tests/models/test_openai_chatcompletions.py tests/models/test_openai_chatcompletions_stream.py -k "rejects_prompt"bash .agents/skills/code-change-verification/scripts/run.shIssue number
Closes #3282
Checks
make lintandmake format