rewrite dac consumer module - #3878
Merged
LKuemmel merged 1 commit intoSep 8, 2026
Merged
Conversation
benderl
force-pushed
the
fixes-dac-comsumer
branch
2 times, most recently
from
August 31, 2026 11:05
c8754c5 to
deaa366
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Reworks generic DAC consumers to support model-driven scaling, live-zero signals, and both M120T outputs.
Changes:
- Centralizes DAC model parameters.
- Adds configurable signal-range mapping.
- Adds separate M120T output selections.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
model.py |
Defines model-specific output parameters. |
consumer.py |
Implements generic scaling and Modbus writes. |
config.py |
Adds signal-range configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
benderl
force-pushed
the
fixes-dac-comsumer
branch
from
August 31, 2026 11:11
deaa366 to
134ad5e
Compare
LKuemmel
marked this pull request as ready for review
September 7, 2026 06:40
LKuemmel
force-pushed
the
feature_consumer_modules
branch
2 times, most recently
from
September 8, 2026 12:32
d06a6eb to
d36e5b8
Compare
LKuemmel
force-pushed
the
fixes-dac-comsumer
branch
from
September 8, 2026 12:38
134ad5e to
35f35a5
Compare
ndrsnhs
approved these changes
Sep 8, 2026
LKuemmel
pushed a commit
that referenced
this pull request
Sep 9, 2026
LKuemmel
pushed a commit
that referenced
this pull request
Sep 9, 2026
LKuemmel
pushed a commit
that referenced
this pull request
Sep 9, 2026
LKuemmel
pushed a commit
that referenced
this pull request
Sep 9, 2026
LKuemmel
pushed a commit
that referenced
this pull request
Sep 9, 2026
LKuemmel
pushed a commit
that referenced
this pull request
Sep 9, 2026
LKuemmel
pushed a commit
that referenced
this pull request
Sep 9, 2026
LKuemmel
pushed a commit
that referenced
this pull request
Sep 9, 2026
LKuemmel
added a commit
that referenced
this pull request
Sep 9, 2026
* modules * Vampair (#3815) * Vampair * typo * review * review * review * add dataclass object for set_power_limit, DAC (#3855) * draft dac * add dataclass object for set_power_limit * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Fix consumer modules (#3865) * fix configuration type hints * fix consumer type hints and errors * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * rewrite dac consumer module (#3878) * fix avm usage (#3913) --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: benderl <benderl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI: openWB/openwb-ui-settings#1070