Skip to content

feat: add to sensor icons, map legacy aliases#988

Merged
zven merged 5 commits into
devfrom
feat/add-sensoricons-and-legacy-aliases
Jun 18, 2026
Merged

feat: add to sensor icons, map legacy aliases#988
zven merged 5 commits into
devfrom
feat/add-sensoricons-and-legacy-aliases

Conversation

@jona159

@jona159 jona159 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 70.06% 2132 / 3043
🔵 Statements 68.58% 2201 / 3209
🔵 Functions 68.07% 420 / 617
🔵 Branches 53.76% 1015 / 1888
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/db/models/sensor.server.ts 65.9% 66.66% 47.05% 67.44% 70-72, 121-126, 151-217, 271
Generated in workflow #2699 for commit da8765d by the Vitest Coverage Report Action

Comment thread app/lib/sensoricons.tsx
@zven

zven commented Jun 18, 2026

Copy link
Copy Markdown
Member

Icons are not shown in tile view:

Screenshot 2026-06-18 at 11 03 53

@jona159

jona159 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Icons are not shown in tile view:

Screenshot 2026-06-18 at 11 03 53

Should be fixed now

@zven zven enabled auto-merge (squash) June 18, 2026 11:08
@zven zven merged commit 2a9147f into dev Jun 18, 2026
6 checks passed
@zven zven deleted the feat/add-sensoricons-and-legacy-aliases branch June 18, 2026 11:12
jona159 added a commit that referenced this pull request Jun 18, 2026
* feat: add to sensor icons, map legacy aliases

* fix: save sensor icon

* fix: render saved sensor icon in tile view

* fix: include icon and status in db call, cast sensortype to map schema property

---------

Co-authored-by: Sven Heitmann <zven@users.noreply.github.com>
zven added a commit that referenced this pull request Jun 18, 2026
* fix: respect sort order

* feat: translations

* feat: add hint how to change sensor order for device owner

* fix: order fresh devices

* feat: add to sensor icons, map legacy aliases (#988)

* feat: add to sensor icons, map legacy aliases

* fix: save sensor icon

* fix: render saved sensor icon in tile view

* fix: include icon and status in db call, cast sensortype to map schema property

---------

Co-authored-by: Sven Heitmann <zven@users.noreply.github.com>

---------

Co-authored-by: Sven Heitmann <zven@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sensor icons can't be updated

2 participants