Skip to content

Fix/device detail respect sort order#987

Merged
zven merged 7 commits into
devfrom
fix/device-detail-respect-sort-order
Jun 18, 2026
Merged

Fix/device detail respect sort order#987
zven merged 7 commits into
devfrom
fix/device-detail-respect-sort-order

Conversation

@jona159

@jona159 jona159 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

  • This PR closes #

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 70.08% 2134 / 3045
🔵 Statements 68.61% 2204 / 3212
🔵 Functions 68.12% 421 / 618
🔵 Branches 53.8% 1018 / 1892
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/db/models/device.server.ts 64.15% 67% 63.41% 64.57% 86-91, 99, 151-152, 221-236, 276, 310, 339, 368, 398, 402, 410-412, 418-420, 438-440, 444-446, 493-647, 698-702, 730-736, 741-757, 836-838, 849, 856-857, 865, 892, 994-1014, 1033
app/db/models/sensor.server.ts 65.9% 66.66% 47.05% 67.44% 70-72, 124-129, 154-220, 274
Generated in workflow #2701 for commit bc1506f by the Vitest Coverage Report Action

@zven

zven commented Jun 18, 2026

Copy link
Copy Markdown
Member

When a device is freshly created and no order is set, the sensor order in the device settings does not match the tile order:

Screenshot 2026-06-18 at 10 30 22

Only after saving the sensor order does their order match in the tile view:

Screenshot 2026-06-18 at 10 32 42

@zven zven linked an issue Jun 18, 2026 that may be closed by this pull request
@jona159

jona159 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

When a device is freshly created and no order is set, the sensor order in the device settings does not match the tile order:

Screenshot 2026-06-18 at 10 30 22 Only after saving the sensor order does their order match in the tile view: Screenshot 2026-06-18 at 10 32 42

Good catch, should be fixed now

Comment thread app/db/models/sensor.server.ts
Comment thread public/locales/de/device-detail-box.json
jona159 and others added 2 commits June 18, 2026 13:35
* feat: add to sensor icons, map legacy aliases

* fix: save sensor icon

* fix: render saved sensor icon in tile view

* fix: include icon and status in db call, cast sensortype to map schema property

---------

Co-authored-by: Sven Heitmann <zven@users.noreply.github.com>
@zven zven merged commit 1046039 into dev Jun 18, 2026
6 checks passed
@zven zven deleted the fix/device-detail-respect-sort-order branch June 18, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make sensor order adjustable for tile view

2 participants