Skip to content

Restore java 25 lts to test matrix, collect coverage on java 25 #8678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 2 commits into from
Jul 31, 2026
+3 −2
Merged

Restore java 25 lts to test matrix, collect coverage on java 25 #8678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f344d76
Restore java 25 lts to test matrix, collect coverage on java 25
jack-berg Jul 31, 2026
d838ea3
Tune DOUBLE_SUM reusable_data allocation rate reduction offset
jack-berg Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,12 @@ jobs:
- 11
- 17
- 21
- 25
- 26 # renovate(java-version)
# Collect coverage on latest LTS
include:
- os: ubuntu-latest
test-java-version: 21
test-java-version: 25
coverage: true
jmh-based-tests: true
steps:
Expand Down
2 changes: 1 addition & 1 deletion ...src/jmhBasedTest/java/io/opentelemetry/sdk/metrics/internal/state/TestInstrumentType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public enum TestInstrumentType {
DOUBLE_SUM(
DoubleSumTester::new,
/* dataAllocRateReductionPercentage= */ 97.3f,
/* allowedPercentOffset= */ 2.0f),
/* allowedPercentOffset= */ 4.0f),

@jack-berg jack-berg Jul 31, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're running jmh-based-test only on the latest LTS, when LTS changed from 21->25 it also changed the memory allocation profile such that we need to tune the assertion parameters in InstrumentGarbageCollectionBenchmarkTest. This here says double_sum memory allocation must reduce by 97+-4%, when going from immutable_data to reuseable_data mode. Previously it was 97+-2%.

LONG_LAST_VALUE(
LongLastValueTester::new,
/* dataAllocRateReductionPercentage= */ 97.3f,
Expand Down
Loading