Skip to content

Rename double-remove TraceState tests and exercise a non-first entry #8672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Draft

Rename double-remove TraceState tests and exercise a non-first entry #8672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions api/all/src/test/java/io/opentelemetry/api/trace/TraceStateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,29 +306,29 @@ void removeNotPresent() {
}

@Test
void removeTwice() {
void removeSameKeyTwice() {
assertThat(firstTraceState.toBuilder().remove(FIRST_KEY).remove(FIRST_KEY).build())
.isEqualTo(TraceState.getDefault());
}

@Test
void removeTwice_KeepsRemainingEntry() {
void removeSameKeyTwice_KeepsRemainingEntry() {
assertThat(multiValueTraceState.toBuilder().remove(FIRST_KEY).remove(FIRST_KEY).build().asMap())
.containsExactly(entry(SECOND_KEY, SECOND_VALUE));
}

@Test
void removeTwice_KeepsRemainingEntries() {
void removeSameKeyTwice_KeepsRemainingEntries() {
assertThat(
TraceState.builder()
.put(FIRST_KEY, FIRST_VALUE)
.put(SECOND_KEY, SECOND_VALUE)
.put(THIRD_KEY, THIRD_VALUE)
.remove(FIRST_KEY)
.remove(FIRST_KEY)
.remove(SECOND_KEY)
.remove(SECOND_KEY)
.build()
.asMap())
.containsExactly(entry(THIRD_KEY, THIRD_VALUE), entry(SECOND_KEY, SECOND_VALUE));
.containsExactly(entry(THIRD_KEY, THIRD_VALUE), entry(FIRST_KEY, FIRST_VALUE));
}

@Test
Expand Down
Loading