Skip to content

Remove assertion in XTA call graph analysis, fixes #368 #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svenkeidel wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove assertion in XTA call graph analysis, fixes #368 #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions OPAL/tac/src/main/scala/org/opalj/tac/fpcf/analyses/cg/xta/TypePropagationAnalysis.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,12 +280,16 @@ final class TypePropagationAnalysis private[analyses] (
// Some sanity checks ...
// Methods with multiple defined methods should never appear as callees.
elidedAssert(!callee.hasMultipleDefinedMethods)

// Instances of DefinedMethod we see should only be those where the method is defined in the class file of
// the declaring class type (i.e., it is not a DefinedMethod instance of some inherited method). However,
// in inconsistent bytecode scenarios, the call graph may resolve to a non-implemented abstract method.
elidedAssert(!callee.hasSingleDefinedMethod ||
(callee.declaringClassType == callee.asDefinedMethod.definedMethod.classFile.thisType) ||
callee.asDefinedMethod.definedMethod.isAbstract)
//
// Assertion removed because of https://github.com/opalj/opal/issues/368
// elidedAssert(!callee.hasSingleDefinedMethod ||
// (callee.declaringClassType == callee.asDefinedMethod.definedMethod.classFile.thisType) ||
// callee.asDefinedMethod.definedMethod.isAbstract)
//

// Remember callee (with PC) so we don't have to process it again later.
state.addSeenCallee(pc, callee)
Expand Down
Loading