Implement TDB execution for verify command - #1283
Merged
Merged
Conversation
This mirrors the structure of TDB execution in QueryCommand: there are separate executeOnDisk and executeInMemory methods that use TDB and in-memory storage, respectively. The two implementations are very similar, so a follow-up refactor could deduplicate the TDB lifecycle handling.
1) Run the same verification queries, but against a Turtle file, since the old `asserted-equiv.owl` was in Manchester syntax 2) add `--fail-on-violation false` to allow the example to be run by integration tests 3) Add equivalent.csv output to satisfy integration tests
Member
|
Sorry for the long delay. I don't have a lot of resources for ROBOT these days, and this is not a feature that I need myself. This PR sticks closely to the existing code in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1282
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedThis mirrors the structure of TDB execution in QueryCommand: there are separate executeOnDisk and executeInMemory methods that use TDB and in-memory storage, respectively.
The two implementations are very similar, so a follow-up refactor could deduplicate the TDB lifecycle handling.
I did not add any tests because there are not similar tests for TDB functionality for either
querynorreportthat I could find.