Get font sizes from theme to account for overrides#97
Merged
Conversation
barry-observation
force-pushed
the
fix-font-size-references
branch
2 times, most recently
from
bcc8f0e to
1647c54
Compare
barry-observation
force-pushed
the
fix-font-size-references
branch
from
1647c54 to
42511d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of solving https://github.com/observation/app/issues/1234
In deze paar plekken kijken we nog naar de
defaultfont sizes, niet naar de font size van hettheme. Daarom worden de overrides nog niet meegenomen en is het niet helemaal consistent.Dit fix alle plekken die ik kon vinden waar we nog
...font.xxxgebruikten in plaats van...theme.font.xxx.Update: dit PR is uitgebreid na overleg met Karel. Het InputField gebruikte onterecht een font size
large. Hierdoor werden de inputs in Observation te groot. We hebben numediumgekozen. Hierdoor blijven ze in Observation gelijk. In ObsIdentify worden ze ietsje kleiner, maar dat is wel correct.