Repository navigation
fix(plugin-detail): a collapsible section prints a plain heading on a print page (objectui#12732) - #12747
Merged
objectstack-fleet[bot] merged 2 commits intoOct 16, 2026
Conversation
… print page (objectui#12732) On a page that declares `print`, a collapsible `record:details` section takes the non-collapsible render: the title, icon, header colour and description print, with no disclosure button, chevron or hover chrome. Off a print page the collapsible header is unchanged. Claude-Session: https://claude.ai/code/session_01RXV3me5Ga2okDdcKJ2Crmc Co-authored-by: Claude <noreply@anthropic.com>
…int-section-chrome
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
Contributor
Author
席位核对 · ACCEPT ·
|
objectstack-fleet
Bot
deleted the
claude/issue-12732-print-section-chrome
branch
October 16, 2026 18:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12732
Clause-②: no
What
On a page that declares
print, a collapsiblerecord:detailssection now prints its header as a plain heading. InDetailSection, the non-collapsible condition becomes "not collapsible, or on a print page". It reuses theisPrintPagevalue that objectui#12717 already reads once above every early return. The printed header keeps the section title, icon, header colour (headerColorClass),showBorderand description, and the content is always shown. The disclosure button,aria-expanded, the chevron and thecursor-pointer/ hover classes no longer print. Off a print page the collapsible branch is unchanged.Tests
detailSectionPrintHeaderChrome-12732.test.tsx: inside aPrintPageProviderthere is no button, noaria-expanded, no lucide chevron and no clickable-header classes, and the icon, header colour, description and values are present. CONTROL outside it: the button witharia-expanded, the chevron, the hover and cursor classes, and click-to-toggle are unchanged.detailSectionPrintPage-11958.test.tsx: the print row used to assert the disclosure button'saria-expanded="true"on paper, which is the defect this card removes. It now asserts that noaria-expandedis present and keeps the values-shown assertion.if (!section.collapsible || isPrintPage) {back toif (!section.collapsible) {):Tests 2 failed | 2 passed (4). Both print rows went red and both controls stayed green. The file was restored from HEAD and its blob hash matches HEAD.pnpm exec vitest run packages/plugin-detail): 2664 passed and 1 failed, the new row's own async-icon timing. That row was fixed and re-run green; the full package run was not repeated on the final head, so CI's run is the reading.DetailSection: 501 passed.Printed page
A console harness page, not the showcase invoice (no backend was booted): two collapsible sections, one authored collapsed, printed to an A4 PDF with Chromium.
aria-expanded.aria-expanded; the title, icon, header colour, description and values all print.The PNGs are on branch
claude/issue-12732-evidenceunderevidence/12732/.Acceptance notes
classNamenow lands on the Card rather than the outer Collapsible wrapper. No caller passes it.opacity-0and draw nothing. This is outside this card.Provenance: built by the cloud session
session_01RXV3me5Ga2okDdcKJ2Crmc(claim6220530801) and opened by thedomain:uiseat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat replaced the dev's own footer lines with this line.Generated by Claude Code