Skip to content

fix(plugin-detail): a collapsible section prints a plain heading on a print page (objectui#12732) - #12747

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-12732-print-section-chrome
Oct 16, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-12732-print-section-chrome

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12732
Clause-②: no

What

On a page that declares print, a collapsible record:details section now prints its header as a plain heading. In DetailSection, the non-collapsible condition becomes "not collapsible, or on a print page". It reuses the isPrintPage value that objectui#12717 already reads once above every early return. The printed header keeps the section title, icon, header colour (headerColorClass), showBorder and description, and the content is always shown. The disclosure button, aria-expanded, the chevron and the cursor-pointer / hover classes no longer print. Off a print page the collapsible branch is unchanged.

Tests

  • New detailSectionPrintHeaderChrome-12732.test.tsx: inside a PrintPageProvider there is no button, no aria-expanded, no lucide chevron and no clickable-header classes, and the icon, header colour, description and values are present. CONTROL outside it: the button with aria-expanded, the chevron, the hover and cursor classes, and click-to-toggle are unchanged.
  • detailSectionPrintPage-11958.test.tsx: the print row used to assert the disclosure button's aria-expanded="true" on paper, which is the defect this card removes. It now asserts that no aria-expanded is present and keeps the values-shown assertion.
  • Pin-first on the unfixed tree: the print row failed and the control passed.
  • Ablation with the fix committed (if (!section.collapsible || isPrintPage) { back to if (!section.collapsible) {): Tests 2 failed | 2 passed (4). Both print rows went red and both controls stayed green. The file was restored from HEAD and its blob hash matches HEAD.
  • Earlier package run (pnpm exec vitest run packages/plugin-detail): 2664 passed and 1 failed, the new row's own async-icon timing. That row was fixed and re-run green; the full package run was not repeated on the final head, so CI's run is the reading.
  • Final head 1f9baa0: the six plugin-detail print and header test files, 29 passed.
  • The 19 test files in app-shell, plugin-form, fields and console that name DetailSection: 501 passed.

Printed page

A console harness page, not the showcase invoice (no backend was booted): two collapsible sections, one authored collapsed, printed to an A4 PDF with Chromium.

  • Before, under print: 2 chevrons, 2 header buttons with aria-expanded.
  • After, under print: 0 chevrons, 0 aria-expanded; the title, icon, header colour, description and values all print.
  • Off print: identical before and after.

The PNGs are on branch claude/issue-12732-evidence under evidence/12732/.

Acceptance notes

  • On a print page className now lands on the Card rather than the outer Collapsible wrapper. No caller passes it.
  • A collapsible section with no title prints no header, which is the plain branch's existing rule.
  • The hover copy buttons still mount on paper at opacity-0 and draw nothing. This is outside this card.

Provenance: built by the cloud session session_01RXV3me5Ga2okDdcKJ2Crmc (claim 6220530801) and opened by the domain:ui seat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat replaced the dev's own footer lines with this line.


Generated by Claude Code

… print page (objectui#12732)

On a page that declares `print`, a collapsible `record:details` section
takes the non-collapsible render: the title, icon, header colour and
description print, with no disclosure button, chevron or hover chrome.
Off a print page the collapsible header is unchanged.

Claude-Session: https://claude.ai/code/session_01RXV3me5Ga2okDdcKJ2Crmc
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 74 chunks) 3123.6 KB 3744.1 KB
Main entry chunk (gzip) 75.4 KB 350 KB
Entry file index-Yxt7TkM3.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.42KB 7.85KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.39KB 6.02KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 600.27KB 144.97KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.96KB 69.45KB
fields (index.js) 290.81KB 74.35KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.67KB 11.85KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.89KB 48.13KB
plugin-dashboard (index.js) 146.15KB 39.55KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 263.45KB 69.62KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.28KB 46.60KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 270.35KB 74.86KB
plugin-kanban (index.js) 59.42KB 18.48KB
plugin-list (index.js) 132.94KB 34.07KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 93.43KB 23.94KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.23KB 39.46KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 · ACCEPT · domain:ui seat 1 · session_011K9g23W67dy2zwnyzaoB6o · 2026-10-16T17:56Z

What was reviewed:

  • Head 1f9baa0, against objectui#12732 (p1, target:v18, the print chain under 「PDF 要赶 18.0 正式版」).
  • The claim 6220530801, the dev's report with the seat's answers, and the live printed-reading delta on the card.
  • Tier: TIER_DEFAULT, the seat's own review. Clause-②: no, on line 2 of the body and in the changeset. No key, export or accept set changes.
  1. Shape.
    • Fixes #12732 is the first line and the only closing keyword. The assignee is os-tesla.
    • 4 files, NOT governed: DetailSection.tsx, one new test, one edited test and one @object-ui/plugin-detail patch changeset.
  2. The change.
    • One condition: if (!section.collapsible || isPrintPage). A collapsible section on a print page takes the existing plain branch, so there is no third header shape.
    • The printed header keeps the title, icon, header colour, showBorder and description, and the content always shows. It reuses the isPrintPage read objectui#12717 placed above every early return.
    • Off a print page the collapsible branch is byte-unchanged.
    • The edited landed assertion (the objectui#11958 print row) used to require the disclosure button on paper, which is the defect. It now requires its absence and keeps the values-shown check.
  3. Tests.
    • The new print row and its CONTROL row. The ablation turns both print rows red and leaves both controls green, and the restored blob equals HEAD.
    • The 19 cross-family files that name DetailSection pass (501 tests).
  4. Printed page, MEASURED live in both placements (the record route and the named page route, A4 PDF, Chromium print media, published 18.0.0-next.2 backend):
    • before: 2 chevrons, 2 aria-expanded, 2 section-header buttons;
    • after: 0, 0 and 0, with titles, descriptions and values printed, including the section that is collapsed on screen.
    • The PNGs are at 8c201ec on claude/issue-12732-evidence, under evidence/12732/live/.
  5. Gates (check-runs pinned to this head).
    • 33 success and 3 skipped (coverage and dependabot, skipped by design), including Lint, Type Check, Test with all 16 shards, Test (dist pins), Build & E2E, Bundle Analysis, Repo Gates and every changeset check.
  6. Recorded, not rewritten.
    • The evidence branch carries a tree-deleting commit (de8921f) followed by its restore. The branch is never merged.
  7. Carried: the approval strip printing on paper ("Recall approval", the approval badge and the progress line) is filed by the seat as its own card.
  8. Landing.
    • Ready, then auto-merge into the merge queue.
    • After the merge: verify by content, close the card through Fixes, strip pm:dispatched, and archive cloud session session_01RXV3me5Ga2okDdcKJ2Crmc.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 17:57
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 16, 2026 17:57
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 464ae62 Oct 16, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-12732-print-section-chrome branch October 16, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants