fix(spec,showcase): trim ChartType taxonomy to renderable types; bump pin#1471
Merged
Conversation
… pin The ChartType taxonomy advertised 38 families, but the Console can only draw ~27 of them — the rest need data shapes the platform doesn't model (OHLC for candlestick/stock, per-record distributions for box-plot/violin), geographic data (choropleth/bubble-map/gl-map), or a renderer the default Recharts engine lacks (sunburst, heatmap, word-cloud, waterfall). Advertising a chart type that can't render is worse than not offering it. - spec: remove the 11 unrenderable types from ChartTypeSchema (keep treemap & sankey — now rendered via Recharts). Update chart/dashboard/report tests; add a guard asserting the dropped types are rejected. - showcase: drop the corresponding chart-gallery widgets; coverage test now asserts the gallery covers exactly the trimmed taxonomy. - bump .objectui-sha → 5265dd31 (treemap/sankey renderer + field-coverage guard). Removed families can return via an opt-in chart renderer plugin once there is real demand and a data model to back them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ChartTypetaxonomy advertised 38 families, but the Console can only draw ~27. The rest need data shapes the platform doesn't model (OHLC → candlestick/stock; per-record distributions → box-plot/violin), geographic data (choropleth/bubble-map/gl-map), or a renderer the default Recharts engine lacks (sunburst, heatmap, word-cloud, waterfall). Advertising a chart type that can't render is worse than not offering it.Changes
ChartTypeSchema(keeptreemap&sankey— now rendered via Recharts in feat(charts): treemap & sankey via Recharts + field-type coverage guard objectui#1438). Update chart/dashboard/report tests; add a guard asserting the dropped types are now rejected..objectui-sha→5265dd31(treemap/sankey renderer + the field-type coverage regression guard).Removed families can return via an opt-in chart renderer plugin once there's real demand and a data model to back them.
Verification
@objectstack/specfull suite: 6609 passed.🤖 Generated with Claude Code