feat(audit): move audit/realtime objects to owning plugins (ADR-0029 K2)#1460
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
dependencies
Decompose the platform-objects monolith further: the audit/activity data
model moves to @objectstack/plugin-audit and presence to
@objectstack/service-realtime, so each plugin owns the sys_* objects its
own behavior produces/observes (ADR-0029 K2/D7/D8).
Objects moved (git mv, preserving history):
- sys_audit_log / sys_activity / sys_comment → @objectstack/plugin-audit
(exactly what the audit writers emit: audit_log + activity rows, and
the sys_comment @mention hook)
- sys_presence → @objectstack/service-realtime
Deliberately left in platform-objects (still registered, not owned here):
- sys_notification — reworked by ADR-0030 messaging.
- sys_attachment — a polymorphic file↔record link that depends on
sys_file; it belongs with @objectstack/service-storage, so it moves in
the storage-domain decomposition rather than being mis-homed under the
audit plugin. The audit plugin keeps registering it (imported from
platform-objects) so it stays available meanwhile.
Wiring:
- Each plugin registers its objects via manifest.register and owns the
Audit Logs setup-nav contribution (D7), so the entry follows the
object that backs it.
- i18n bundles (en/zh-CN/ja-JP/es-ES) extracted into each plugin and
loaded on kernel:ready (D8). Seeded from the platform-objects bundles
so existing translations are preserved; regenerate with
`os i18n extract` against each scripts/i18n-extract.config.ts.
- platform-objects audit barrel + i18n-extract config + tests updated
to drop the moved objects (orphan generated translations remain as
the accepted interim state, matching the security/sharing/webhooks
moves).
Adds canonical-identity tests for the moved audit objects (parity with
the existing sys_presence test).
os-zhuang
force-pushed
the
claude/adr-0029-k2-audit-ownership
branch
from
a019892 to
823aae9
Compare
xuyushun441-sys
pushed a commit
that referenced
this pull request
Jun 2, 2026
feat(studio): designer ↔ global-chat context + "Ask AI" entry point (P1) (#1460) objectui@58471fdeb4aa11dceaaaa4956430eece234a2fac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the ADR-0029 K2 decomposition of the
platform-objectsmonolith. The audit/activity data model moves to its capability plugins so each owns thesys_*objects its behavior produces/observes.Objects moved (
git mv, history preserved):sys_audit_log/sys_activity/sys_comment→@objectstack/plugin-audit— exactly what the audit writers emit (audit_log + activity rows) and hook (sys_comment @mention notifications).sys_presence→@objectstack/service-realtime.Deliberately not moved (still registered, not owned here):
sys_notification— reworked by ADR-0030 messaging.sys_attachment— re-evaluated: it's a polymorphic file↔record link depending onsys_file, which is owned by@objectstack/service-storage. The audit writers never touch it; it was only grouped underaudit/by the old folder layout. It belongs with storage and will move in the storage-domain decomposition PR, not here. The audit plugin keeps registering it (imported from platform-objects) so it stays available meanwhile.Wiring (D7 + D8)
manifest.registerand owns the Audit Logs setup-nav contribution (D7), so the menu entry follows the object that backs it. (Relies on the D7 serving-path fix in fix(objectql): apply D7 setup-nav contributions in the protocol serving path (empty Setup menu) #1457.)en/zh-CN/ja-JP/es-ES) extracted into each plugin, loaded onkernel:ready(D8). Seeded from the platform-objects bundles so existing hand-translations are preserved. Regenerate withos i18n extractagainst eachscripts/i18n-extract.config.ts.Tests
plugin-audit: 12 passed (new canonical-identity tests for the 3 owned objects).service-realtime: 23 passed (incl. movedsys_presencetest).platform-objects: 52 passed.pnpm turbo buildgreen.https://claude.ai/code/session_01Tv6F1Ub6bhCedrx3r8sZM4