You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(deps): downgrade @vitejs/plugin-legacy to v7 - #1925
Up to 8.0.2, it referenced config.build.rollupOptions, so it happened to work with Vite 7.
Since 8.1.0, it references config.build.rolldownOptions instead. This property does not exist in Vite 7, so the build fails with the following error. This is the cause of the built / vite / legacy failure in chore(deps): update all non-major dependencies #1865.
TypeError: Cannot destructure property 'output' of 'rolldownOptions' as it is undefined.
@vitejs/plugin-vue2 only supports up to Vite 7 (and its repository is archived), so we cannot move to Vite 8. Therefore, this PR goes back to v7, which officially supports Vite 7.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 33c9a0f2-acbe-40d3-9d8e-b531ba3b8e4b
📥 Commits
Reviewing files that changed from the base of the PR and between 8430959 and 0cc3365.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
packages/bridge/package.json
renovate.json
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
📝 Walkthrough
Walkthrough
The bridge package changes its @vitejs/plugin-legacy dependency range from ^8.0.2 to ^7.2.1. The Renovate configuration limits updates for this package to versions below 8.
The dependency and lockfile consistently select plugin-legacy 7.2.1, and no concrete merge-blocking issue is established.
Pre-merge checks | 5
✅ Passed checks (5 passed)
Check name
Status
Explanation
Title check
The title clearly and concisely identifies the dependency downgrade to version 7, which is the main change.
Description check
The description explains the downgrade to version 7, the Vite 7 compatibility issue, and the Renovate restriction. It is directly related to the changeset.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 ESLint
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
Error: typescript-eslint does not support TS 7.0.
at Object. (/.eslint-tmp/node_modules/.pnpm/typescript-eslint@8.71.1_eslint@9.39.4_supports-color@7.2.0__supports-color@7.2.0_typescript@7.0.2/node_modules/typescript-eslint/dist/index.js:52:11)
at Module._compile (node:internal/modules/cjs/loader:1830:14)
at Object..js (node:internal/modules/cjs/loader:1961:10)
at Module.load (node:internal/modules/cjs/loader:1553:32)
at Module._load (node:internal/modules/cjs/loader:1355:12)
at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
at loadCJSModuleWithModuleLoad (node:internal/modules/esm/translators:326:3)
at ModuleWrap. (node:internal/modules/esm/translators:231:7)
at ModuleJob.run (node:internal/modules/esm/module_job:437:25)
at async node:internal/modules/esm/loader:639:26
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR downgrades
@vitejs/plugin-legacyto v7 (7.2.1) and prevents Renovate from updating it to v8.Background
@vitejs/plugin-legacywas upgraded to v8, but v8 requiresvite: ^8.0.0as a peer dependency.config.build.rollupOptions, so it happened to work with Vite 7.config.build.rolldownOptionsinstead. This property does not exist in Vite 7, so the build fails with the following error. This is the cause of thebuilt/vite/legacyfailure in chore(deps): update all non-major dependencies #1865.TypeError: Cannot destructure property 'output' of 'rolldownOptions' as it is undefined.
@vitejs/plugin-vue2only supports up to Vite 7 (and its repository is archived), so we cannot move to Vite 8. Therefore, this PR goes back to v7, which officially supports Vite 7.📝 Checklist