Skip to content

chore(deps): downgrade @vitejs/plugin-legacy to v7 - #1925

Merged
danielroe merged 1 commit into
mainfrom
chore/plugin-legacy-v7
Oct 11, 2026
Merged

danielroe merged 1 commit into
mainfrom
chore/plugin-legacy-v7

Conversation

@wattanx

@wattanx wattanx commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR downgrades @vitejs/plugin-legacy to v7 (7.2.1) and prevents Renovate from updating it to v8.

Background

  • In chore(deps): update dependency @vitejs/plugin-legacy to v8 #1758, @vitejs/plugin-legacy was upgraded to v8, but v8 requires vite: ^8.0.0 as a peer dependency.
  • Up to 8.0.2, it referenced config.build.rollupOptions, so it happened to work with Vite 7.
  • Since 8.1.0, it references config.build.rolldownOptions instead. This property does not exist in Vite 7, so the build fails with the following error. This is the cause of the built / vite / legacy failure in chore(deps): update all non-major dependencies #1865.
    TypeError: Cannot destructure property 'output' of 'rolldownOptions' as it is undefined.
  • @vitejs/plugin-vue2 only supports up to Vite 7 (and its repository is archived), so we cannot move to Vite 8. Therefore, this PR goes back to v7, which officially supports Vite 7.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​vitejs/​plugin-legacy@​8.0.2 ⏵ 7.2.19910010091 -3100

View full report

@pkg-pr-new

pkg-pr-new Bot commented Oct 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/bridge@1925
npm i https://pkg.pr.new/@nuxt/bridge-schema@1925

commit: 0cc3365

@wattanx
wattanx marked this pull request as ready for review October 11, 2026 08:09
@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 33c9a0f2-acbe-40d3-9d8e-b531ba3b8e4b

📥 Commits

Reviewing files that changed from the base of the PR and between 8430959 and 0cc3365.


⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)
  • packages/bridge/package.json
  • renovate.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

The bridge package changes its @vitejs/plugin-legacy dependency range from ^8.0.2 to ^7.2.1. The Renovate configuration limits updates for this package to versions below 8.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes


Merge Risk: ⚪ Minimal · up to 0cc33

The dependency and lockfile consistently select plugin-legacy 7.2.1, and no concrete merge-blocking issue is established.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the dependency downgrade to version 7, which is the main change.
Description check Passed The description explains the downgrade to version 7, the Vite 7 compatibility issue, and the Renovate restriction. It is directly related to the changeset.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/bridge/package.json

typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1

Oops! Something went wrong! :(

ESLint: 9.39.4

Error: typescript-eslint does not support TS 7.0.
at Object. (/.eslint-tmp/node_modules/.pnpm/typescript-eslint@8.71.1_eslint@9.39.4_supports-color@7.2.0__supports-color@7.2.0_typescript@7.0.2/node_modules/typescript-eslint/dist/index.js:52:11)
at Module._compile (node:internal/modules/cjs/loader:1830:14)
at Object..js (node:internal/modules/cjs/loader:1961:10)
at Module.load (node:internal/modules/cjs/loader:1553:32)
at Module._load (node:internal/modules/cjs/loader:1355:12)
at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
at loadCJSModuleWithModuleLoad (node:internal/modules/esm/translators:326:3)
at ModuleWrap. (node:internal/modules/esm/translators:231:7)
at ModuleJob.run (node:internal/modules/esm/module_job:437:25)
at async node:internal/modules/esm/loader:639:26



Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wattanx
wattanx requested a review from danielroe October 11, 2026 08:12
@danielroe
danielroe merged commit 551c465 into main Oct 11, 2026
47 of 48 checks passed
@danielroe
danielroe deleted the chore/plugin-legacy-v7 branch October 11, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants