Skip to content

[18.0][OU-FIX] base: align extension view types with their parent #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eantones wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][OU-FIX] base: align extension view types with their parent #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions openupgrade_scripts/scripts/base/18.0.1.3/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,32 @@ def _fix_list_view_type(cr):
openupgrade.logged_query(cr, "UPDATE ir_ui_view SET type='list' WHERE type='tree'")


def _align_extension_view_types(cr):
"""
Align extension views' type with their parent view's type.

Old databases carry extension views (mode='extension') whose stored type
doesn't match their parent's: older Odoo versions stored a wrong
derivation (e.g. the 'form' default on a list-view extension) and never
validated it. Odoo 18 validates the resolved arch root against ``type``
on every module update, turning each of these rows into a hard
ParseError. The invariant an extension view must satisfy is simply "same
type as its parent" - enforce it. Run after the tree->list rename so the
alignment lands on the renamed values.
"""
openupgrade.logged_query(
cr,
"""
UPDATE ir_ui_view c
SET type = p.type
FROM ir_ui_view p
WHERE c.inherit_id = p.id
AND c.mode = 'extension'
AND c.type != p.type
""",
)


def _fix_list_view_mode(cr):
"""
Previous actions had a default value of tree,form, but now the default is list,form.
Expand Down Expand Up @@ -92,6 +118,7 @@ def migrate(cr, version):
table="ir_act_window_view",
)
_fix_list_view_type(cr)
_align_extension_view_types(cr)
_fix_list_view_mode(cr)
_fix_serbian_res_lang_record(cr)
_fix_company_layout_background(cr)
Loading