fix: prevent code ligatures from being applied when disabled in diff viewer#3034
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
📝 WalkthroughWalkthroughThe diff line renderer now wraps each rendered segment in a ChangesDiff rendering
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gameroman
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
fix #2754
🧭 Context
While the normal code viewer respects the ligature setting, the diff viewer ignores the same setting.
📚 Description
Ligatures style is applied here:
npmx.dev/app/assets/main.css
Lines 290 to 293 in 636d8ad
But the diff viewer has no
<code>block in the code line. This change ensures to have<code>for each line and apply the ligatures setting.Example result
In https://main.npmx.dev/diff/nitro/v/2.2.28...3.0.260610-beta?file=lib/class-file.js, this line
if( this.__.src === undefined ) this.load();will be rendered as follows:Before
After
https://npmxdev-git-shuuji3-fixligature-in-diff-viewer-npmx.vercel.app/diff/nitro/v/2.2.28...3.0.260610-beta?file=lib/class-file.js