feat: blog-release rainbow-comet#2969
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughExtends ChangesBluesky Gallery Embed Support
rainbow-comet Release Blog Post
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| <BlueskyPostEmbed url="https://bsky.app/profile/danielroe.dev/post/3mn5sk7jrwk2v" /> | ||
|
|
||
| <BlueskyPostEmbed url="https://bsky.app/profile/npmx.dev/post/3mlwz4gho5s2n" /> | ||
|
|
There was a problem hiding this comment.
It would be good to also add the talk we did at Web Engines Hackfest https://mu.social/profile/npmx.dev/post/3mp75vauw322e
There was a problem hiding this comment.
I added, but decided not to add embed support, as it would be too long. But let me know if we still need it :)
There was a problem hiding this comment.
Great to me. Later on, it would be good that the link is clickable. We can walk there once we add more social posts related features though.
|
About the authors, I think it is good to have the people that did some features listed. Maybe you, Philippe, alec, and willow (for the work on the meetup). And you can remove me. Looking forward to seeing this post out! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/components/global/BlueskyPostEmbed.client.vue (1)
223-229: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winReuse
img.aspectRatioin the gallery path.The single-image branch already reserves space with
aspectRatio, but the new gallery branch drops that and will reflow as images load. Carrying the same style across here would reduce layout shift in the strip.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/components/global/BlueskyPostEmbed.client.vue` around lines 223 - 229, The gallery rendering path in BlueskyPostEmbed.client.vue is missing the same reserved sizing used in the single-image branch, which can cause layout shift as images load. Update the v-for image markup that renders post.embed.items to carry over img.aspectRatio styling/handling from the single-image branch so the gallery strip reserves space consistently before each image loads.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/pages/blog/release/rainbow-comet.md`:
- Around line 41-97: The release post is triggering too many client-side Bluesky
lookups because each BlueskyPostEmbed still uses url-based embeds that resolve
handles at runtime. Update the embeds in this page to use uri= values instead of
url=, or pre-resolve/batch the post identifiers before publishing, so
app/components/global/BlueskyPostEmbed.client.vue is not forced to make multiple
first-load requests for each embed.
---
Nitpick comments:
In `@app/components/global/BlueskyPostEmbed.client.vue`:
- Around line 223-229: The gallery rendering path in BlueskyPostEmbed.client.vue
is missing the same reserved sizing used in the single-image branch, which can
cause layout shift as images load. Update the v-for image markup that renders
post.embed.items to carry over img.aspectRatio styling/handling from the
single-image branch so the gallery strip reserves space consistently before each
image loads.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b92ab902-ed19-43fa-a0cc-6faa0489c951
⛔ Files ignored due to path filters (5)
public/blog/coderabbit-x-npmx.pngis excluded by!**/*.pngpublic/blog/languages-rainbow-comet.pngis excluded by!**/*.pngpublic/blog/noodles-rainbow-comet.pngis excluded by!**/*.pngpublic/blog/og/release-rainbow-comet.pngis excluded by!**/*.pngpublic/blog/stats-tab.pngis excluded by!**/*.png
📒 Files selected for processing (2)
app/components/global/BlueskyPostEmbed.client.vueapp/pages/blog/release/rainbow-comet.md
3 participants
🧭 Context
It's time for a new release. We've accumulated too many wonderful things and news