feat(i18n): add Korean translations#2933
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesKorean (ko-KR) locale activation
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello! Thank you for opening your first PR to npmx, @yeonjulee1005! 🚀 Here’s what will happen next:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
graphieros
left a comment
There was a problem hiding this comment.
Thank you! 🌿
I do not speak Korean, and could only check with translation tools, and LGTM.
|
@graphieros Thank you for your review! 😉 |
|
Hi! Sorry to bother, but I also have created a pull request #2862 2 weeks ago with the same feature. Could you check that out as well? |
|
@kimkanu However, after reviewing the PR you mentioned, it seems to include a In our case, I think it would be better for native Korean developers to participate directly in the translation process instead. @graphieros , I would also appreciate your input on this matter. |
@yeonjulee1005, as a non Korean speaker, I can only trust you find an agreement on an approach that is most maintainable and accurate. |
|
@yeonjulee1005 , thank you for your considerate comment. Personally, as another native speaker of Korean language, I think choosing the correct josa is one of the most important feature of Korean translation. I find it very distracting if there's something wrong with josa, or the page is using something like "은(는)" to include both cases. Not only that they seem imperfect and not caring Korean readers, but also it could be distracting for screen reader users because the pronunciations are quite different -- though I'm not a screen reader user, so I'm not 100% sure on this point. I agree on the point that using bunch of custom modifiers makes the code complicated, especially compared to other languages. And my code has a lot of heuristics which are incorrect under a handful of circumstances. I'm really open to find a good sweet spot between complexity and correctness. :) |
|
I totally agree with your point on josa it's genuinely That said, I think the most pragmatic sweet spot here might be simpler than any heuristic: leave Korean-specific grammar decisions to native Korean-speaking contributors. So rather than trying to solve it in code, it might be worth setting a contribution guideline that Korean translations should be reviewed or contributed by native speakers, similar to how some projects handle RTL languages or complex scripts. Happy to help improve the Korean translations directly if that's useful! 😊 |
🔗 Linked issue
🧭 Context
Adds Korean (ko-KR) translations and registers the locale.
📚 Description
Added a new
ko-KR.jsonlocale and updatedconfig/i18n.tsaccordingly.