Fixed the CI failures — ready for re-review! 🙏
The starttag override was accidentally a module-level function instead of an HTML5Translator method (bare super() + missing return), which is what ruff/mypy/pyright/ty were flagging. It is now a proper method override matching the docutils signature, always delegating to super().starttag(). Also dropped a redundant condition in i18n.py.
Verified locally: ruff clean on all touched lines, plus test_intl (61), test_build_html and test_config (123) all pass.
Originally posted by @hesam-oxe in sphinx-doc/sphinx#14429 (comment)
Fixed the CI failures — ready for re-review! 🙏
The
starttagoverride was accidentally a module-level function instead of anHTML5Translatormethod (baresuper()+ missing return), which is what ruff/mypy/pyright/ty were flagging. It is now a proper method override matching the docutils signature, always delegating tosuper().starttag(). Also dropped a redundant condition ini18n.py.Verified locally: ruff clean on all touched lines, plus
test_intl(61),test_build_htmlandtest_config(123) all pass.Originally posted by @hesam-oxe in sphinx-doc/sphinx#14429 (comment)