Repository navigation
fix(nsolid): read source by the script's thread and its exact path - #81
Merged
Merged
Conversation
get_source_code looks a script up by its V8 id on one thread, and the process matches the path exactly as it loaded it (an ES module's keeps file://). Stripping file://, /app or /usr/src/app never finds it, so the skills no longer retry with tweaked paths: they pass the path as the profile, sample or stack gives it, with that thread's threadId, and go on without the code if the call fails. Event stacks give the thread as latest.threadId when they ran on a worker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
WalkthroughDocs-only change to four skill files. Assessment
Verdict: APPROVE — focused, consistent documentation fix; removes retry paths that can never match and pins each runtime source read to its thread. CI is green on all three OSes. |
ns-control-tower
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
get_source_codelooks a script up by its V8 id on one thread. The process also matches the path exactly as it loaded the script, so an ES module's path keepsfile://. The skills told the model to retry a failed call withfile://,/appor/usr/src/appstripped, or with leading segments removed. Those retries can never match. Now the skills:threadId;ns-analyze-event, take the process and thread fromevent_stacks:latest.agentId, andlatest.threadIdwhen the stack ran on a worker thread.This follows the N|Solid Console 7 MCP server, which adds
latest.threadIdtoevent_stacksand makesget_source_codelook only at the profiles of the thread asked for.Checks
The pre-commit hook (lint, typecheck, tests) passed under Node 22.
🤖 Generated with Claude Code