-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: add orama logo #8829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add orama logo #8829
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,3 +59,10 @@ | |
| justify-end | ||
| lg:ml-8; | ||
| } | ||
|
|
||
| .oramaLogo { | ||
| @apply h-3 | ||
| w-auto | ||
| text-neutral-900 | ||
| dark:text-neutral-100; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,17 +5,13 @@ import { | |
| ArrowDownIcon, | ||
| ArrowUpIcon, | ||
| } from '@heroicons/react/24/solid'; | ||
| import Image from 'next/image'; | ||
| import OramaLogo from '@node-core/ui-components/Icons/PartnerLogos/Orama/Logo'; | ||
| import { useTranslations } from 'next-intl'; | ||
|
Comment on lines
+8
to
9
|
||
| import { useTheme } from 'next-themes'; | ||
|
|
||
| import styles from './index.module.css'; | ||
|
|
||
| export const Footer = () => { | ||
| const t = useTranslations(); | ||
| const { resolvedTheme } = useTheme(); | ||
|
|
||
| const oramaLogo = `https://website-assets.oramasearch.com/orama-when-${resolvedTheme}.svg`; | ||
|
|
||
| return ( | ||
| <div className={styles.footer}> | ||
|
|
@@ -54,12 +50,7 @@ export const Footer = () => { | |
| className={styles.poweredByLink} | ||
| > | ||
| <small>{t('components.search.poweredBy')}</small> | ||
| <Image | ||
| src={oramaLogo} | ||
| alt={t('components.search.poweredBy')} | ||
| width="62" | ||
| height="12" | ||
| /> | ||
| <OramaLogo className={styles.oramaLogo} /> | ||
| </a> | ||
| </div> | ||
| </div> | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,21 @@ | ||||||
| import classNames from 'classnames'; | ||||||
|
|
||||||
| import type { FC, SVGProps } from 'react'; | ||||||
|
|
||||||
| const Orama: FC<SVGProps<SVGSVGElement>> = ({ className, ...props }) => ( | ||||||
| <svg | ||||||
| xmlns="http://www.w3.org/2000/svg" | ||||||
| viewBox="1580 680 2900 460" | ||||||
| fill="none" | ||||||
| aria-hidden="true" | ||||||
| {...props} | ||||||
| className={classNames('h-3 w-auto', className)} | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hardcoded size classes reduce Logo component reusabilityLow Severity The Orama Additional Locations (1)Reviewed by Cursor Bugbot for commit 90b1258. Configure here.
|
||||||
| className={classNames('h-3 w-auto', className)} | |
| className={classNames(className)} |
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,3 @@ | ||||||||||||||||
| import Logo from './Logo'; | ||||||||||||||||
|
|
||||||||||||||||
| export { Logo }; | ||||||||||||||||
|
Comment on lines
+1
to
+3
|
||||||||||||||||
| import Logo from './Logo'; | |
| export { Logo }; | |
| import Favicon from './Favicon'; | |
| import Logo from './Logo'; | |
| export { Favicon, Logo }; |


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renderSmallPartnernow returnsnullwhen a partner logo module doesn’t exportFavicon, butgetPartners()still slices to the requestedlengthbefore rendering. This can lead to fewer thanlengthpartners being shown (e.g., when a new partner like ORAMA has onlyLogo). Prefer ensuring every partner logo exports aFavicon, or add a fallback (e.g., renderLogo.Logowith small sizing) / filter partners with a favicon before slicing so the UI consistently renders the requested count.