lib: fix AbortSignal.any() nested composite leak

[DariusHQ]

Fixes: #66612
Refs: #62367

AbortSignal.any() copies the source WeakRefs of a composite input into the new composite, so nested composites share them. Since #62367 those WeakRefs are also the unregister tokens of sourceSignalsCleanupRegistry. When the inner composite is collected first, its cleanup therefore also unregisters the outer composite, and an observed outer composite stays in gcPersistentSignals after all of its sources are gone.

This uses each composite's own WeakRef as the unregister token, so collecting one composite only removes its own registrations.

The new test in test-abortsignal-drop-settled-signals.mjs fails without the change and passes with it. The reproduction from the issue goes from 8/8 to 0/8 retained composites.

[github-actions]

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

• the guide for first-time contributors
• the contribution and automation policies
• the pull request guide
• the AI use policy
• the Code of Conduct

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.43%. Comparing base (dd9777b) to head (3e0d631).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #66617      +/-   ##
==========================================
- Coverage   92.78%   90.43%   -2.35%     
==========================================
  Files         422      791     +369     
  Lines      193692   276587   +82895     
  Branches    29881    53112   +23231     
==========================================
+ Hits       179714   250135   +70421     
- Misses      13650    16860    +3210     
- Partials      328     9592    +9264     

Files with missing lines	Coverage Δ
lib/internal/abort_controller.js	95.41% <100.00%> (+0.01%)	⬆️

... and 499 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78303/

[DariusHQ]

@atlowChemi thanks for the review! CI run 78303 failed only on node-test-commit-osx (macos15-x64). macOS arm64 and every other platform passed, including test-abortsignal-drop-settled-signals. I can't access the Jenkins logs, so I can't tell which test failed there. Could you take a look and, if it's unrelated, add resume-ci, then commit-queue once it's green? Thanks!

[gurgunday]

lgtm

[github-actions]

Failed to resume CI

✖ CI job 78303 is in status RUNNING, skipping resume

Full Auto Start CI output

�[36m⠋�[39m Validating Jenkins credentials
�[36m⠋�[39m Validating Jenkins credentials
✔  Jenkins credentials valid
�[36m⠙�[39m Looking for CI runs for pull request 66617
�[36m⠙�[39m Looking for CI runs for pull request 66617
�[36m⠙�[39m Getting PR from nodejs/node/pull/66617
�[36m⠙�[39m Getting reviews from nodejs/node/pull/66617
�[36m⠙�[39m Getting comments from nodejs/node/pull/66617
✔  Found PR CI job 78303
�[36m⠹�[39m Querying data for job/node-test-pull-request/78303/
�[36m⠹�[39m Querying data for job/node-test-pull-request/78303/
�[36m⠹�[39m Querying API for job/node-test-pull-request/78303/
✔  Build data downloaded
   ✖  CI job 78303 is in status RUNNING, skipping resume

View workflow run

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78321/