Skip to content

src: remove orphaned js_udp_wrap test binding - #66399

Open
Renegade334 wants to merge 1 commit into
nodejs:mainfrom
Renegade334:remove-js-udp-wrap
Open

Renegade334 wants to merge 1 commit into
nodejs:mainfrom
Renegade334:remove-js-udp-wrap

Conversation

@Renegade334

Copy link
Copy Markdown
Member

The test-only js_udp_wrap binding was added in #33380, and the test utility it backed was removed in #54825, leaving it orphaned.

It is not visible via process.binding(), so removing it should be a formality.

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 29, 2026
@Renegade334 Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@addaleax

Copy link
Copy Markdown
Member

Is this something that would be used/useful for the upcoming QUIC work? Asking because the TCP equivalent is for HTTP/1.1 and HTTP/2

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.40%. Comparing base (e6b3f96) to head (6b17ea3).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66399      +/-   ##
==========================================
+ Coverage   90.38%   90.40%   +0.02%     
==========================================
  Files         792      791       -1     
  Lines      275517   275392     -125     
  Branches    52813    52788      -25     
==========================================
- Hits       249017   248965      -52     
+ Misses      16912    16840      -72     
+ Partials     9588     9587       -1     
Files with missing lines Coverage Δ
src/node_binding.cc 70.79% <ø> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334

Copy link
Copy Markdown
Member Author

Is this something that would be used/useful for the upcoming QUIC work? Asking because the TCP equivalent is for HTTP/1.1 and HTTP/2

I'm fairly confident that the answer is no, Brand New Quic™ endpoints don't wrap UDP handles in the JS layer like the mothballed implementation did, they initialise and store their own private Endpoint::UDP handles in C++.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants