Skip to content

vfs: unflag - #66318

Open
mcollina wants to merge 2 commits into
nodejs:mainfrom
mcollina:unflag-node-vfs
Open

mcollina wants to merge 2 commits into
nodejs:mainfrom
mcollina:unflag-node-vfs

Conversation

@mcollina

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/ffi
  • @nodejs/security-wg
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 26, 2026
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Comment thread lib/internal/process/pre_execution.js
@mcollina
mcollina marked this pull request as ready for review September 29, 2026 14:21
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Keep VFS enabled by default while allowing the negated flag to disable
node:vfs exposure and --vfs-load.

Assisted-by: pi
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.37%. Comparing base (95279e7) to head (99c479f).
⚠️ Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66318      +/-   ##
==========================================
- Coverage   92.78%   90.37%   -2.41%     
==========================================
  Files         422      792     +370     
  Lines      192238   275502   +83264     
  Branches    29636    52803   +23167     
==========================================
+ Hits       178367   248996   +70629     
- Misses      13548    16924    +3376     
- Partials      323     9582    +9259     
Files with missing lines Coverage Δ
lib/internal/vfs/file_system.js 99.63% <100.00%> (-0.01%) ⬇️
lib/vfs.js 100.00% <100.00%> (ø)
src/node.cc 79.24% <100.00%> (ø)
src/node_options.cc 81.59% <ø> (ø)
src/node_options.h 95.67% <100.00%> (ø)

... and 514 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants