Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
mcollina
force-pushed
the
fix/fast-utf8-stream-max-write-retries
branch
from
September 25, 2026 08:34
f803775 to
919e61f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66275 +/- ##
==========================================
+ Coverage 90.28% 90.37% +0.08%
==========================================
Files 790 792 +2
Lines 271642 275527 +3885
Branches 51846 52803 +957
==========================================
+ Hits 245260 249008 +3748
- Misses 16889 16929 +40
- Partials 9493 9590 +97
🚀 New features to boost your workflow:
|
Port the SonicBoom tests that could not be imported directly because they depend on the third-party proxyquire module, along with the maxWriteRetries option they exercise, into the Utf8Stream module. Adds maxWriteRetries support, which bounds consecutive EAGAIN/EBUSY retry attempts and resets the counter on forward progress, plus drop-event and flush-callback edge-case coverage. Fixes: nodejs#58955 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#66275 Assisted-by: pi
mcollina
force-pushed
the
fix/fast-utf8-stream-max-write-retries
branch
from
September 29, 2026 10:27
919e61f to
7309c02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the SonicBoom tests that could not be imported directly because they depend on the third-party proxyquire module, along with the maxWriteRetries option they exercise, into the Utf8Stream module.
Adds maxWriteRetries support, which bounds consecutive EAGAIN/EBUSY retry attempts and resets the counter on forward progress, plus drop-event and flush-callback edge-case coverage.
Fixes: #58955
AI generated, reviewed by me