Skip to content

test: mark test-repl-user-error-handler as flaky - #64612

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:mark-repl-test-flaky
Jul 26, 2026
Merged

test: mark test-repl-user-error-handler as flaky#64612
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:mark-repl-test-flaky

Conversation

@avivkeller

Copy link
Copy Markdown
Member

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 19, 2026
Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller force-pushed the mark-repl-test-flaky branch from 1a813de to db343de Compare July 19, 2026 23:50
@avivkeller avivkeller added repl Issues and PRs related to the REPL subsystem. v8 engine Issues and PRs related to the V8 dependency. inspector Issues and PRs related to the V8 inspector protocol flaky-test Issues and PRs related to the tests with unstable failures on the CI. and removed needs-ci PRs that need a full CI run. labels Jul 19, 2026
@Archkon

Archkon commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Should these tests be considered as flaky test ?

parallel/test-repl-context
parallel/test-repl-use-global

And I encounter same problem with "Uncaught Error [ERR_INSPECTOR_COMMAND]: Inspector error -32000: Promise was collected"
https://github.com/nodejs/node/actions/runs/29719200410/job/88278594681
https://github.com/nodejs/node/actions/runs/29717783702/job/88274497079
If so, could you rerun the failed github action check due to flaky test of #64604 ? Thanks !

@avivkeller

Copy link
Copy Markdown
Member Author

@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 22, 2026
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (0bcc6ef) to head (db343de).
⚠️ Report is 75 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64612      +/-   ##
==========================================
- Coverage   90.14%   90.14%   -0.01%     
==========================================
  Files         741      741              
  Lines      242080   242080              
  Branches    45563    45574      +11     
==========================================
- Hits       218213   218211       -2     
  Misses      15375    15375              
- Partials     8492     8494       +2     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 24, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 24, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64612
✔  Done loading data for nodejs/node/pull/64612
----------------------------------- PR info ------------------------------------
Title      test: mark test-repl-user-error-handler as flaky (#64612)
Author     Aviv Keller <me@aviv.sh> (@avivkeller)
Branch     avivkeller:mark-repl-test-flaky -> nodejs:main
Labels     repl, v8 engine, test, inspector, flaky-test, author ready
Commits    1
 - test: mark test-repl-user-error-handler as flaky
Committers 1
 - Aviv Keller <me@aviv.sh>
PR-URL: https://github.com/nodejs/node/pull/64612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 19 Jul 2026 23:47:32 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64612#pullrequestreview-4756881859
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/64612#pullrequestreview-4773603121
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/30108943788

@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 24, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@trivikr trivikr added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 893602c into nodejs:main Jul 26, 2026
99 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 893602c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants