test: mark test-repl-user-error-handler as flaky - #64612
Merged
Merged
Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
avivkeller
force-pushed
the
mark-repl-test-flaky
branch
from
July 19, 2026 23:50
1a813de to
db343de
Compare
Contributor
|
Should these tests be considered as flaky test ? And I encounter same problem with "Uncaught Error [ERR_INSPECTOR_COMMAND]: Inspector error -32000: Promise was collected" |
Member
Author
jasnell
approved these changes
Jul 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64612 +/- ##
==========================================
- Coverage 90.14% 90.14% -0.01%
==========================================
Files 741 741
Lines 242080 242080
Branches 45563 45574 +11
==========================================
- Hits 218213 218211 -2
Misses 15375 15375
- Partials 8492 8494 +2 🚀 New features to boost your workflow:
|
richardlau
approved these changes
Jul 24, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64612 ✔ Done loading data for nodejs/node/pull/64612 ----------------------------------- PR info ------------------------------------ Title test: mark test-repl-user-error-handler as flaky (#64612) Author Aviv Keller <me@aviv.sh> (@avivkeller) Branch avivkeller:mark-repl-test-flaky -> nodejs:main Labels repl, v8 engine, test, inspector, flaky-test, author ready Commits 1 - test: mark test-repl-user-error-handler as flaky Committers 1 - Aviv Keller <me@aviv.sh> PR-URL: https://github.com/nodejs/node/pull/64612 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64612 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 19 Jul 2026 23:47:32 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64612#pullrequestreview-4756881859 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/64612#pullrequestreview-4773603121 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/30108943788 |
Collaborator
Collaborator
Collaborator
daeyeon
approved these changes
Jul 25, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
|
Landed in 893602c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we wait for https://issues.chromium.org/issues/536271637