build: add manually-dispatched stress-test workflow#64118
Conversation
|
Review requested:
|
nodejs-github-bot
added
the
meta
joyeecheung
changed the title
joyeecheung
force-pushed
the
stress-workflow
branch
from
a929666 to
1a81765
Compare
|
How would I trigger this on a PR created from the contributor's fork? |
This version only allows triggering from a branch in the repo the workflow file is in - you could still do it from a PR, just that PR must come from a branch here (which also means you need to have write access here). If someone wants to make it work for a fork I think that can be a follow up, but be aware that allowing runs from forks can carry security risks, and to make this action useful there's an argument that allows arbitrary arguments to I think for the best balance between usefulness v.s. safety it's better to only allow people with write access in this repo to test from a branch in this repo. If they want to run it from a fork, just use an action from that fork, but not from this repo. So to your question - pull that contributor's branch to your fork, and run that action from your fork. |
I only asked because of the description that specifically mentions PRs. I'm fine with the scope-as is. |
|
PRs are still possible, just that the PRs need to come from a branch in repo, not from a fork e.g. the PR must be |
Add a GitHub action workflow that can be manually dispatched to stress-run tests on a PR/branch to verify flakiness. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
force-pushed
the
stress-workflow
branch
from
1a81765 to
3c12ff7
Compare
|
Fixed the linter complaints. Can you take a look again? Thanks! @panva @Renegade334 |
|
Updated the config a bit and tried to clarify how to make the cache hit in the workflow name. @panva @Renegade334 Can you take a look again? Thanks! |
|
@Renegade334 I think I have addressed your comments - do you mind if I land it as-is? |
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 29ca673 |
Add a GitHub action workflow that can be manually dispatched to stress-run tests on a PR/branch to verify flakiness. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: nodejs#64118 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
|
Gave it a try on the main branch, looks like it's working as intended https://github.com/nodejs/node/actions/runs/28582481101/job/84745887552 |
4 participants
Add a GitHub action workflow that can be manually dispatched to stress-run tests on a PR/branch to verify flakiness.