debugger: lazily wait for initial break output#63969
Open
trivikr wants to merge 1 commit into
Open
Conversation
5f512d0 to
77d19fe
Compare
Member
Author
|
Marked as draft as there are many CI to failures. |
Wait for the initial pause render before completing debugger REPL startup, but only when the initial pause is actually observed during startup initialization. Creating the wait promise before Runtime.runIfWaitingForDebugger() can hang when the debug target exits or disconnects without producing an initial pause event. It also assumes the inspector object always has parsed CLI options, which is not true for tests that use a minimal mock inspector. Create the initial-render wait lazily from the Debugger.paused handler while startup initialization is active. This preserves prompt ordering for normal initial breaks without blocking startup when no initial pause render occurs. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
77d19fe to
70ed2a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a flaky
test-debugger-run-after-quit-restartfailure where the debuggerREPL could display
debug>before the initial break output had been rendered.The startup path now waits for the first local
--inspect-brkpause render tofinish before completing REPL startup, but only when that pause render is
observed during startup initialization. This preserves the prompt ordering fix
without hanging when the debug target exits or disconnects before producing an
initial pause event.
Refs:
Error Log
Assisted-by: openai:gpt-5.5