Skip to content

readline: reject pending question promise on close#63266

Open
watilde wants to merge 1 commit into
nodejs:mainfrom
watilde:readline
Open

readline: reject pending question promise on close#63266
watilde wants to merge 1 commit into
nodejs:mainfrom
watilde:readline

Conversation

@watilde
Copy link
Copy Markdown
Member

@watilde watilde commented May 12, 2026

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels May 12, 2026
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 12, 2026

Can you change the subsystem from lib: to readline: please?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (6009d93) to head (07e1df6).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63266   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         714      714           
  Lines      225242   225254   +12     
  Branches    42575    42588   +13     
=======================================
+ Hits       202856   202872   +16     
+ Misses      14172    14169    -3     
+ Partials     8214     8213    -1     
Files with missing lines Coverage Δ
lib/internal/readline/interface.js 97.35% <100.00%> (+0.01%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watilde watilde changed the title lib: reject pending question promise on close readline: reject pending question promise on close May 13, 2026
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 13, 2026

You also need to run git commit --amend -s to fix the linter

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants