Repository navigation
Commit-queue should automatically handle PRs with merge commits from the target branch #967
Description
Activity
it feels like we should be able to handle these automatically without much trouble.
It would require changing how to pick up commits quite a lot though, and would only work for
--fixupAll/commit-queue-squashlanding sessions. Currently we download the patches fromhttps://github.com/nodejs/node/pulls/${PR_ID}.patch, but in order to support merge commits, we'd probably have to fetch to actual PR head branchI thought merge commits weren't supported by the Jenkins CI workflows anyway but it looks like it wasn't an issue for that PR
I thought merge commits weren't supported by the Jenkins CI workflows anyway but it looks like it wasn't an issue for that PR
Maybe a side effect of having
COMMIT_SHA_CHECKis that the CI now supports merge commits?I thought merge commits weren't supported by the Jenkins CI workflows anyway but it looks like it wasn't an issue for that PR
FWIW the Jenkins CI doesn't explicitly block merge commits but it does attempt to rebase PRs onto the base branch (e.g.
main) and it's that rebase that more often than not fails for merge commits.
Some contributors merge into their PR branch from
mainrather than rebasing. We might not recommend this, but it shouldn't be a major issue. Unfortunately it seems that the commit-queue label can't handle this, and fails with:Here's a example I just ran into: nodejs/node#59375 (comment). More examples here.
AFAICT this then always requires manually landing the PR, but it feels like we should be able to handle these automatically without much trouble.