Repository navigation
[BUG] corepack not use COREPACK_NPM_REGISTRY install of tarball #792
Description
Activity
I looked at this. The
replaceon line 249 is harmless, the arguments run the other way. The real gap is that it only rewrites tarball URLs that start withhttps://registry.npmjs.org, so when the registry inCOREPACK_NPM_REGISTRYadvertisesdist.tarballon another host (the upstream it mirrors, a CDN), the download goes there instead, and without the token sincehttpUtils.fetchonly attaches it for the configured origin. I'll open a PR that resolves the tarball path against the configured registry.Reacted by kuolemax
When the
COREPACK_NPM_REGISTRYenvironment variable is set, the tarball mirror URL is always used instead of the one set inCOREPACK_NPM_REGISTRY.This is likely because the URL in line 243 of
installVersionis overwritten with the tarball address, but thereplacefunction in line 249 still replaces it withDEFAULT_NPM_REGISTRY_URL.